PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Make jsonrpc-test a dev dependency #16

Merged
glyph merged 7 commits from jsonrpc_test_dev_dep into main 2021-11-08 09:54:21 +00:00
Conversation 1 Commits 7 Files Changed 10 +53 -143
glyph commented 2021-11-05 11:40:54 +00:00
Owner
Copy Link

This PR addresses Issue #10.

The jsonrpc-test crate is moved from [dependencies] to [dev-dependencies]. It has been removed as a dependency from some crates which were not using it (ie. peach-menu and peach-probes).

This PR addresses [Issue #10](https://git.coopcloud.tech/PeachCloud/peach-workspace/issues/10). The `jsonrpc-test` crate is moved from `[dependencies]` to `[dev-dependencies]`. It has been removed as a dependency from some crates which were not using it (ie. `peach-menu` and `peach-probes`).
glyph added 7 commits 2021-11-05 11:40:55 +00:00
move jsonrpc test to dev deps for buttons 0f1ee3a36c
remove newline 042ab55182
remove jsonrpc test dep 2c59c33b35
move jsonrpc test to dev deps for network 7f815075d2
move jsonrpc test to dev deps for oled d482ef39c4
remove jsonrpc test crate for probe 15ec1fbcfc
update lockfile 66a9b12285
glyph requested review from notplants 2021-11-05 11:41:15 +00:00
notplants commented 2021-11-08 09:41:16 +00:00
Owner
Copy Link

LGTM

LGTM
glyph merged commit 42d8649bdd into main 2021-11-08 09:54:21 +00:00
glyph deleted branch jsonrpc_test_dev_dep 2021-11-08 09:54:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
notplants
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#16
No description provided.
Delete Branch "jsonrpc_test_dev_dep"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?