Add SSB-related templates #21

glyph · 2021-11-12T08:44:02Z

glyph commented

2021-11-12 08:44:02 +00:00

This PR includes templates for all SSB-related functionality. These templates are currently being coded without template variables; those will be added later when we have the context object builders and underlying code in place.

Profile
Peers menu
Peers list
Settings menu
SSB settings menu
~~- Status~~ (will do this one later)

Note: I'm going to perform the refactor of template and route organisation in a separate PR. For now I'm mostly focusing just on writing templates.

This PR includes templates for all SSB-related functionality. These templates are currently being coded without template variables; those will be added later when we have the context object builders and underlying code in place. - [x] Profile - [x] Peers menu - [x] Peers list - [x] Settings menu - [x] SSB settings menu ~~- [ ] Status~~ (will do this one later) ----- Note: I'm going to perform the refactor of template and route organisation in a separate PR. For now I'm mostly focusing just on writing templates.

glyph added the

enhancement

peach-web

labels 2021-11-12 08:44:02 +00:00

glyph added 2 commits 2021-11-12 08:44:03 +00:00

a9f318e2e3 update profile template

0514cb6a38 update classes and icons

glyph added 1 commit 2021-11-12 08:54:42 +00:00

c3b9ffef0e update peers menu template

glyph added 1 commit 2021-11-12 09:37:46 +00:00

166f860050 add peers list template

glyph referenced this pull request

2021-11-12 09:41:52 +00:00

Coordinating front-end and back-end development of SSB features #20

glyph added 1 commit 2021-11-12 09:56:52 +00:00

b8289fb000 remove preview

glyph added 1 commit 2021-11-12 10:11:04 +00:00

44fd6beb98 add root settings menu

glyph added 1 commit 2021-11-12 10:26:41 +00:00

ceabfad54f add ssb settings menu template

glyph added 3 commits 2021-11-13 08:53:53 +00:00

dd189e89e0 improve indendation

06117f377d improve indentation

67d86e2874 replace flash and noscript with snippets

glyph changed title from ~~WIP: Add SSB-related templates~~ to Add SSB-related templates

2021-11-13 12:47:31 +00:00

glyph requested review from notplants 2021-11-13 12:47:43 +00:00

glyph commented

2021-11-13 12:50:31 +00:00

@notplants

This is now ready for review. I have not included all SSB-related templates (for example, the status page); those will come later. I'm hoping that this is enough for you to work with in the meantime. I'd like to merge this so I can work on improving the other templates and routes; for example, separating the settings and status concerns.

I introduced some small indentation and whitespace changes in this PR, along with using your snippets pattern throughout all templates (for flash_message and noscript).

@notplants This is now ready for review. I have not included all SSB-related templates (for example, the status page); those will come later. I'm hoping that this is enough for you to work with in the meantime. I'd like to merge this so I can work on improving the other templates and routes; for example, separating the settings and status concerns. I introduced some small indentation and whitespace changes in this PR, along with using your `snippets` pattern throughout all templates (for `flash_message` and `noscript`).

notplants commented

2021-11-15 07:17:50 +00:00

@glyph LGTM. this will be great to work on from. going to start on this today.

It looks to me like ssb_settings.tera isn't currently connected to any route, is this intentional?

@glyph LGTM. this will be great to work on from. going to start on this today. It looks to me like ssb_settings.tera isn't currently connected to any route, is this intentional?

glyph commented

2021-11-15 07:33:15 +00:00

@notplants

Thanks for taking a look! Yup, I've intentionally tried to keep this PR purely about templates and will do the route connections in a separate PR :)

@notplants Thanks for taking a look! Yup, I've intentionally tried to keep this PR purely about templates and will do the route connections in a separate PR :)

👍 1

glyph merged commit 0b26113fc9 into main

2021-11-15 07:43:28 +00:00

glyph referenced this issue from a commit

2021-11-15 07:43:29 +00:00

Merge pull request 'Add SSB-related templates' (#21) from ssb_templates into main

glyph deleted branch ssb_templates

2021-11-15 07:43:29 +00:00

Sign in to join this conversation.

No reviewers