This PR includes templates for all SSB-related functionality. These templates are currently being coded without template variables; those will be added later when we have the context object builders and underlying code in place.
Profile
Peers menu
Peers list
Settings menu
SSB settings menu - [ ] Status (will do this one later)
Note: I'm going to perform the refactor of template and route organisation in a separate PR. For now I'm mostly focusing just on writing templates.
This PR includes templates for all SSB-related functionality. These templates are currently being coded without template variables; those will be added later when we have the context object builders and underlying code in place.
- [x] Profile
- [x] Peers menu
- [x] Peers list
- [x] Settings menu
- [x] SSB settings menu
~~- [ ] Status~~ (will do this one later)
-----
Note: I'm going to perform the refactor of template and route organisation in a separate PR. For now I'm mostly focusing just on writing templates.
This is now ready for review. I have not included all SSB-related templates (for example, the status page); those will come later. I'm hoping that this is enough for you to work with in the meantime. I'd like to merge this so I can work on improving the other templates and routes; for example, separating the settings and status concerns.
I introduced some small indentation and whitespace changes in this PR, along with using your snippets pattern throughout all templates (for flash_message and noscript).
@notplants
This is now ready for review. I have not included all SSB-related templates (for example, the status page); those will come later. I'm hoping that this is enough for you to work with in the meantime. I'd like to merge this so I can work on improving the other templates and routes; for example, separating the settings and status concerns.
I introduced some small indentation and whitespace changes in this PR, along with using your `snippets` pattern throughout all templates (for `flash_message` and `noscript`).
@glyph LGTM. this will be great to work on from. going to start on this today.
It looks to me like ssb_settings.tera isn't currently connected to any route, is this intentional?
@glyph LGTM. this will be great to work on from. going to start on this today.
It looks to me like ssb_settings.tera isn't currently connected to any route, is this intentional?
Thanks for taking a look! Yup, I've intentionally tried to keep this PR purely about templates and will do the route connections in a separate PR :)
@notplants
Thanks for taking a look! Yup, I've intentionally tried to keep this PR purely about templates and will do the route connections in a separate PR :)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
notplants
This PR includes templates for all SSB-related functionality. These templates are currently being coded without template variables; those will be added later when we have the context object builders and underlying code in place.
- [ ] Status(will do this one later)Note: I'm going to perform the refactor of template and route organisation in a separate PR. For now I'm mostly focusing just on writing templates.
@notplants
This is now ready for review. I have not included all SSB-related templates (for example, the status page); those will come later. I'm hoping that this is enough for you to work with in the meantime. I'd like to merge this so I can work on improving the other templates and routes; for example, separating the settings and status concerns.
I introduced some small indentation and whitespace changes in this PR, along with using your
snippetspattern throughout all templates (forflash_messageandnoscript).@glyph LGTM. this will be great to work on from. going to start on this today.
It looks to me like ssb_settings.tera isn't currently connected to any route, is this intentional?
@notplants
Thanks for taking a look! Yup, I've intentionally tried to keep this PR purely about templates and will do the route connections in a separate PR :)