PeachCloud
/
peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests Projects Releases Wiki Activity

Separate network settings and status templates #30

Merged
glyph merged 6 commits from cleanup_network_settings into main 2021-11-18 09:49:19 +00:00
Conversation 1 Commits 6 Files Changed 17 +424 -239
glyph commented 2021-11-16 15:14:48 +00:00
Owner
Copy Link
  • Add a network status template and associated route
  • Move network status logic (remove from settings)
  • Rename network settings templates (remove the network_ prefix)
  • Remove admin-related buttons from the network settings menu
  • Remove Cancel button from power menu
  • Minor CSS addition and changes
- Add a network status template and associated route - Move network status logic (remove from settings) - Rename network settings templates (remove the `network_` prefix) - Remove admin-related buttons from the network settings menu - Remove `Cancel` button from power menu - Minor CSS addition and changes
glyph added 6 commits 2021-11-16 15:14:49 +00:00
glyph added the
peach-web
 label 2021-11-16 15:14:58 +00:00
glyph requested review from notplants 2021-11-16 15:15:01 +00:00
glyph added the
refactor
 label 2021-11-16 15:15:09 +00:00
notplants commented 2021-11-18 09:10:47 +00:00
Owner
Copy Link

LGTM.

clean kitchen, clean routes, tasty soup

LGTM. clean kitchen, clean routes, tasty soup
👍 1
glyph merged commit c3917d0f0f into main 2021-11-18 09:49:19 +00:00
glyph deleted branch cleanup_network_settings 2021-11-18 09:49:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
notplants
Labels
Clear labels
  
bug

Something is not working

  
documentation

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
maintenance

Pruning and weeding

  
peach-lib

   
peach-network

   
peach-oled

   
peach-stats

   
peach-web

   
question

More information is needed

  
refactor

Code rewrite

  
wontfix

This won't be fixed

No Label
bug
documentation
duplicate
enhancement
help wanted
invalid
maintenance
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
refactor
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#30
No description provided.
Delete Branch "cleanup_network_settings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?