Fix broken JS and tweak styling (CSS & HTML) #33
No reviewers
Labels
No Label
bug
documentation
duplicate
enhancement
help wanted
invalid
maintenance
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
refactor
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: PeachCloud/peach-workspace#33
Loading…
Reference in New Issue
No description provided.
Delete Branch "js_and_style_fixes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This was intended to be a JS-fix-only PR but I had a lapse in discipline and some CSS+HTML changes slipped into the mix.
@notplants previously did the great work of separating the
flashMsg
JS function intocommon.rs
. This PR removes all the duplicate instances of that function which remained in the codebase.This also fixes some of the JS functions which were named incorrectly (in
change_password.js
andconfigure_dns.js
).JS for updating network status has been removed from
network_card.js
. This is no longer necessary, since we have separated settings and status into different templates.Minor HTML and CSS updates were introduced to a few templates:
I'd rather leave styling updates to the end - after we've added all the backend functionality and UI - but I sometimes I get carried away 😅
Ah, there's a conflict here but I don't see any difference between
src/routes/authentication.rs
in the current PR andmain
? -_-OK, I merged
main
into this branch and pushed a commit. Seems like the conflict has been resolved and I don't think I've introduced any unwanted code.LG
a lil styling sometimes slips in, I understand
glad to see more code abstracted and less duplication