Error refactor for peach-lib #38

glyph · 2021-11-25T10:21:21Z

glyph commented

2021-11-25 10:21:21 +00:00

This is a major refactor of the PeachError type, with associated changes to error-handling throughout the codebase of peach-lib. The snafu dependency has been removed in favour of a custom error implementation. The PeachError variants have also been refined to reduce unnecessary duplication by grouping related errors (total number of variants has been reduced from 27 to 19).

The refactored src/error.rs code is fully documented.

I imagine some fine-tuning may be required as we interact with this library via peach-web and other consumers.

Other Changes

Added module paths for imported functions (for example, config_manager::get_admin_password_hash())
Grouped related use statements by dependency
Removed unnecessary borrows to satisfy clippy
Remove all instances of unwrap() and expect()
Minor code changes to improve idiomaticity and/or ergonomics

This is a major refactor of the `PeachError` type, with associated changes to error-handling throughout the codebase of `peach-lib`. The `snafu` dependency has been removed in favour of a custom error implementation. The `PeachError` variants have also been refined to reduce unnecessary duplication by grouping related errors (total number of variants has been reduced from 27 to 19). The refactored `src/error.rs` code is fully documented. I imagine some fine-tuning may be required as we interact with this library via `peach-web` and other consumers. **Other Changes** - Added module paths for imported functions (for example, `config_manager::get_admin_password_hash()`) - Grouped related `use` statements by dependency - Removed unnecessary borrows to satisfy `clippy` - Remove all instances of `unwrap()` and `expect()` - Minor code changes to improve idiomaticity and/or ergonomics

glyph added 7 commits 2021-11-25 10:21:22 +00:00