PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Remove jsonrpc from peach-stats #43

Merged
glyph merged 4 commits from separate_stats_logic into main 2021-12-13 05:20:58 +00:00
Conversation 1 Commits 4 Files Changed 9 +224 -381
glyph commented 2021-12-09 07:48:57 +00:00
Owner
Copy Link

This is the first step in separating core logic from JSON-RPC server code.

  • Removes all JSON-RPC crates and code
  • Removes Debian packaging assets
  • Moves data types (structs.rs) into stats.rs (this is a more idiomatic approach for Rust)
  • Offers Serialize and Deserialize for structs with either serde or miniserde (using feature flags)
  • Bumps version to 0.2.0
  • Changes error variants to tuple structs
  • Brings code comment documentation to 100% coverage
This is the first step in separating core logic from JSON-RPC server code. - Removes all JSON-RPC crates and code - Removes Debian packaging assets - Moves data types (`structs.rs`) into `stats.rs` (this is a more idiomatic approach for Rust) - Offers `Serialize` and `Deserialize` for structs with either serde or miniserde (using feature flags) - Bumps version to `0.2.0` - Changes error variants to tuple structs - Brings code comment documentation to 100% coverage
glyph added 1 commit 2021-12-09 07:48:58 +00:00
remove jsonrpc from peach-stats 0907fbc474
glyph added 1 commit 2021-12-09 07:55:01 +00:00
add docs about feature flags 8c3fecb875
glyph requested review from notplants 2021-12-09 07:55:38 +00:00
glyph added the
refactor
peach-stats
 labels 2021-12-09 07:55:46 +00:00
glyph added 4 commits 2021-12-13 05:13:11 +00:00
jsonrpc server with peach-stats methods 33486b4e1d
update lockfile d240741958
fix paths in documentation code examples f9231f0bc9
bump version to 0.2.0 7b4090f56f
glyph force-pushed separate_stats_logic from 7b4090f56f to 8c3fecb875 2021-12-13 05:16:44 +00:00 Compare
glyph added 2 commits 2021-12-13 05:19:25 +00:00
fix example code cfbf052d27
bump version fb6d0317b6
glyph commented 2021-12-13 05:20:48 +00:00
Author
Owner
Copy Link
  • clippy is happy
  • tests are passing

I'm merging this (after some unfortunate git shenanigans which required a commit revert).

- `clippy` is happy - tests are passing I'm merging this (after some unfortunate git shenanigans which required a commit revert).
glyph merged commit 06e48deb3a into main 2021-12-13 05:20:58 +00:00
glyph deleted branch separate_stats_logic 2021-12-13 05:20:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
notplants
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
peach-stats
refactor
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#43
No description provided.
Delete Branch "separate_stats_logic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?