Remove jsonrpc from peach-network #46

glyph · 2021-12-14T13:11:30Z

glyph commented

2021-12-14 13:11:30 +00:00

Continuing the theme of separating core logic from JSON-RPC services.

Replaces snafu with a custom error implementation
Removes all JSON-RPC crates and code
Removes Debian packaging assets
Offers Serialize and Deserialize for structs with either serde or miniserde (using feature flags)
Bumps version to 0.3.0
Brings code comment documentation to 100% coverage

Next, I will add these network methods to the peach-jsonrpc-server repo.

Continuing the theme of separating core logic from JSON-RPC services. - Replaces `snafu` with a custom error implementation - Removes all JSON-RPC crates and code - Removes Debian packaging assets - Offers Serialize and Deserialize for structs with either serde or miniserde (using feature flags) - Bumps version to 0.3.0 - Brings code comment documentation to 100% coverage Next, I will add these network methods to the `peach-jsonrpc-server` repo.

glyph added the

refactor

peach-network

labels 2021-12-14 13:11:30 +00:00

glyph added 14 commits 2021-12-14 13:11:31 +00:00

2429ea8fdd replace rand with nanorand and bump version

cd8e5737c4 implement custom error type

79c94e6af0 replace snafu with custom error type

c3fa188400 testing refactored wpactrl

46b7c0fc2b update wpactrl tests

2f7c7aac8f bump version and fix wpactrl dep import

dfa1306b2d update lockfile

8032b83c41 resolve merge conflicts

f4113f0632 remove debian files and main

4f5eb3aa04 update dependencies and version

9f40378fce remove json-rpc error code and improve docs

287082381e remove json-rpc methods

a824be53b9 update docs and remove unnecessary structs

1986d31461 feature flag docs and license

notplants commented

2021-12-14 18:47:13 +00:00

nice nice. I feel all this work will be worth it for the simplification it brings!

glyph commented

2021-12-14 18:54:35 +00:00

Thanks for taking a look :) I think so too. Earlier today I was thinking about how nice it'll be to only have to update JSON-RPC server depedencies in one manifest.

glyph merged commit 4d6dbd511e into main

2021-12-14 18:55:16 +00:00

glyph deleted branch split_network_logic

2021-12-14 18:55:16 +00:00

glyph referenced this issue from a commit

2021-12-14 18:55:17 +00:00

Merge pull request 'Remove jsonrpc from peach-network' (#46) from split_network_logic into main

Sign in to join this conversation.

No reviewers