PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Remove jsonrpc from peach-network #46

Merged
glyph merged 14 commits from split_network_logic into main 2021-12-14 18:55:16 +00:00
Conversation 2 Commits 14 Files Changed 9 +562 -1784
glyph commented 2021-12-14 13:11:30 +00:00
Owner
Copy Link

Continuing the theme of separating core logic from JSON-RPC services.

  • Replaces snafu with a custom error implementation
  • Removes all JSON-RPC crates and code
  • Removes Debian packaging assets
  • Offers Serialize and Deserialize for structs with either serde or miniserde (using feature flags)
  • Bumps version to 0.3.0
  • Brings code comment documentation to 100% coverage

Next, I will add these network methods to the peach-jsonrpc-server repo.

Continuing the theme of separating core logic from JSON-RPC services. - Replaces `snafu` with a custom error implementation - Removes all JSON-RPC crates and code - Removes Debian packaging assets - Offers Serialize and Deserialize for structs with either serde or miniserde (using feature flags) - Bumps version to 0.3.0 - Brings code comment documentation to 100% coverage Next, I will add these network methods to the `peach-jsonrpc-server` repo.
glyph added the
refactor
peach-network
 labels 2021-12-14 13:11:30 +00:00
glyph added 14 commits 2021-12-14 13:11:31 +00:00
replace rand with nanorand and bump version 2429ea8fdd
implement custom error type cd8e5737c4
replace snafu with custom error type 79c94e6af0
testing refactored wpactrl c3fa188400
update wpactrl tests 46b7c0fc2b
bump version and fix wpactrl dep import 2f7c7aac8f
update lockfile dfa1306b2d
resolve merge conflicts 8032b83c41
remove debian files and main f4113f0632
update dependencies and version 4f5eb3aa04
remove json-rpc error code and improve docs 9f40378fce
remove json-rpc methods 287082381e
update docs and remove unnecessary structs a824be53b9
feature flag docs and license 1986d31461
notplants commented 2021-12-14 18:47:13 +00:00
Owner
Copy Link

nice nice. I feel all this work will be worth it for the simplification it brings!

nice nice. I feel all this work will be worth it for the simplification it brings!
glyph commented 2021-12-14 18:54:35 +00:00
Author
Owner
Copy Link

Thanks for taking a look :) I think so too. Earlier today I was thinking about how nice it'll be to only have to update JSON-RPC server depedencies in one manifest.

Thanks for taking a look :) I think so too. Earlier today I was thinking about how nice it'll be to only have to update JSON-RPC server depedencies in one manifest.
glyph merged commit 4d6dbd511e into main 2021-12-14 18:55:16 +00:00
glyph deleted branch split_network_logic 2021-12-14 18:55:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
peach-network
refactor
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#46
No description provided.
Delete Branch "split_network_logic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?