PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Borked PR: Fix setup of nsupdate. Add installation of dnsutils. Dynamically get dynamic dns server domain. #58

Closed
notplants wants to merge 1 commits from fix-nsupdate into permissions
pull from: fix-nsupdate
merge into: PeachCloud:permissions
Conversation 1 Commits 1 Files Changed 7 +21 -15
notplants commented 2021-12-18 16:27:55 +00:00
Owner
Copy Link

This PR changes the dyndns code in peach-lib to look up the domain of the dynamic dns server to talk to from config.yml.

This is more flexible, and allows me to more easily test multiple servers (prod and staging), and could also allow easier changing to a new dynamic dns server in the future.

I also additionally added installation of dnsutils to the peach-config setup script, which was missing before, and is required for the use of nsupdate by dyndns-updater.

This PR changes the dyndns code in peach-lib to look up the domain of the dynamic dns server to talk to from config.yml. This is more flexible, and allows me to more easily test multiple servers (prod and staging), and could also allow easier changing to a new dynamic dns server in the future. I also additionally added installation of dnsutils to the peach-config setup script, which was missing before, and is required for the use of nsupdate by dyndns-updater.
notplants added 1 commit 2021-12-18 16:27:55 +00:00
Fix setup of nsupdate 29cc40be48
notplants changed title from Fix setup of nsupdate to Fix setup of nsupdate. Add installation of dnsutils. Dynamically get dynamic dns server domain. 2021-12-18 16:28:26 +00:00
notplants closed this pull request 2021-12-22 17:18:24 +00:00
notplants commented 2021-12-22 17:21:15 +00:00
Author
Owner
Copy Link

some gitea issus... going to re-create this PR from another branch

some gitea issus... going to re-create this PR from another branch
notplants changed title from Fix setup of nsupdate. Add installation of dnsutils. Dynamically get dynamic dns server domain. to Borked PR: Fix setup of nsupdate. Add installation of dnsutils. Dynamically get dynamic dns server domain. 2021-12-22 17:22:10 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#58
No description provided.
Delete Branch "fix-nsupdate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?