PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Merged Elsewhere: Fix setup of nsupdate. Add installation of dnsutils. Dynamically get dynamic dns server domain. #59

Closed
notplants wants to merge 0 commits from fix-nsupdate2 into main
pull from: fix-nsupdate2
merge into: PeachCloud:main
Conversation 1 Commits - Files Changed -
notplants commented 2021-12-22 17:21:59 +00:00
Owner
Copy Link

This PR changes the dyndns code in peach-lib to look up the domain of the dynamic dns server to talk to from config.yml.

This is more flexible, and allows me to more easily test multiple servers (prod and staging), and could also allow easier changing to a new dynamic dns server in the future.

I also additionally added installation of dnsutils to the peach-config setup script, which was missing before, and is required for the use of nsupdate by dyndns-updater.

This PR changes the dyndns code in peach-lib to look up the domain of the dynamic dns server to talk to from config.yml. This is more flexible, and allows me to more easily test multiple servers (prod and staging), and could also allow easier changing to a new dynamic dns server in the future. I also additionally added installation of dnsutils to the peach-config setup script, which was missing before, and is required for the use of nsupdate by dyndns-updater.
notplants added 3 commits 2021-12-22 17:22:00 +00:00
Fix setup of nsupdate 29cc40be48
Debugging dyndns b8f394b901
Merge branch 'main' of https://git.coopcloud.tech/PeachCloud/peach-workspace into main3 c75608fb1a
notplants commented 2022-01-12 15:38:41 +00:00
Author
Owner
Copy Link

the changes in this PR were included in this merged PR #63

closing this PR

the changes in this PR were included in this merged PR https://git.coopcloud.tech/PeachCloud/peach-workspace/pulls/63 closing this PR
notplants closed this pull request 2022-01-12 15:38:42 +00:00
notplants deleted branch fix-nsupdate2 2022-01-12 15:38:46 +00:00
notplants changed title from WIP: Fix setup of nsupdate. Add installation of dnsutils. Dynamically get dynamic dns server domain. to Merged Elsewhere: Fix setup of nsupdate. Add installation of dnsutils. Dynamically get dynamic dns server domain. 2022-01-12 15:39:08 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#59
No description provided.
Delete Branch "fix-nsupdate2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?