PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Replace outdated crypto crate #61

Merged
glyph merged 1 commits from replace_rust_crypto into main 2022-01-04 16:33:27 +00:00
Conversation 2 Commits 1 Files Changed 3 +55 -25
glyph commented 2022-01-04 13:28:34 +00:00
Owner
Copy Link

While attempting to build peach-web for aarch64-unknown-linux-gnu I ran into a build error for rust-crypto. Upon investigation, I learned that this crate is unmaintained and has not been updated in over 5 years.

This PR replaces rust-crypto with the sha3 crate (maintained by the RustCrypto org).

While attempting to build `peach-web` for `aarch64-unknown-linux-gnu` I ran into a build error for `rust-crypto`. Upon investigation, I learned that this crate is unmaintained and has not been updated in over 5 years. This PR replaces `rust-crypto` with the `sha3` crate (maintained by the [RustCrypto org](https://github.com/RustCrypto)).
glyph added the
maintenance
peach-lib
 labels 2022-01-04 13:28:34 +00:00
glyph added 1 commit 2022-01-04 13:28:35 +00:00
replace outdated crypto crate 446927f587
glyph requested review from notplants 2022-01-04 13:28:56 +00:00
notplants commented 2022-01-04 15:28:30 +00:00
Owner
Copy Link

nice find!

funny with internet that sometimes a tutorial you are reading is actually from years ago and outdated

nice find! funny with internet that sometimes a tutorial you are reading is actually from years ago and outdated
notplants commented 2022-01-04 15:28:34 +00:00
Owner
Copy Link

LGTM

LGTM
glyph merged commit 6792e4702d into main 2022-01-04 16:33:27 +00:00
glyph deleted branch replace_rust_crypto 2022-01-04 16:33:27 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
notplants
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
maintenance
peach-lib
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#61
No description provided.
Delete Branch "replace_rust_crypto"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?