Replace miniserde_support with serde_support for peach-jsonrpc-server #64

glyph · 2022-01-12T10:24:48Z

glyph commented

2022-01-12 10:24:48 +00:00

As noted in PR#63, I had accidentally broken the ability to compile at the workspace-level.

This occurred because one of the workspace crates used the miniserde_support feature flag from peach-stats and another crate used the serde_support feature flag. This caused a conflict, with cargo trying to compile with both feature flags simultaneously enabled. TIL.

I've replaced miniserde_support with serde_support in peach-jsonrpc-server and things are now working.

CC: @notplants

As noted in [PR#63](https://git.coopcloud.tech/PeachCloud/peach-workspace/pulls/63#issuecomment-11472), I had accidentally broken the ability to compile at the workspace-level. This occurred because one of the workspace crates used the `miniserde_support` feature flag from `peach-stats` and another crate used the `serde_support` feature flag. This caused a conflict, with `cargo` trying to compile with both feature flags simultaneously enabled. TIL. I've replaced `miniserde_support` with `serde_support` in `peach-jsonrpc-server` and things are now working. CC: @notplants

👍 1

glyph added the

maintenance

label 2022-01-12 10:24:48 +00:00

glyph added 1 commit 2022-01-12 10:24:49 +00:00

replace miniserde_support with serde_support c6f8591600

glyph merged commit 6f5cefa367 into main

2022-01-12 10:25:01 +00:00

glyph referenced this issue from a commit

2022-01-12 10:25:01 +00:00

Merge pull request 'Replace miniserde_support with serde_support for peach-jsonrpc-server' (#64) from fix_workspace_comp into main

glyph deleted branch fix_workspace_comp