Add sbot configuration route and template #71

glyph · 2022-01-17T13:30:55Z

glyph commented

2022-01-17 13:30:55 +00:00

Add route for /settings/scuttlebutt/configure
Add Sbot Configuration template
Reorganise Scuttlebutt Settings template

Screenshots below :)

UX note: after clicking Save or Restore Defaults, the page reloads with a flash message notifying the user that the sbot will need to be restarted before the changes take effect.

@notplants - Add route for `/settings/scuttlebutt/configure` - Add `Sbot Configuration` template - Reorganise `Scuttlebutt Settings` template Screenshots below :) ----- UX note: after clicking `Save` or `Restore Defaults`, the page reloads with a flash message notifying the user that the sbot will need to be restarted before the changes take effect.

DeepinScreenshot_select-area_20220117152525.png

28 KiB

DeepinScreenshot_select-area_20220117152540.png

29 KiB

glyph added 4 commits 2022-01-17 13:30:56 +00:00

add route for sbot config 3bb00c4eb7

mount routes for sbot config 8f5b257ed1

add sbot config template and rename menu 8c4cf6261e

add bottom margin for small label class b4a930e774

glyph requested review from notplants 2022-01-17 13:31:32 +00:00

glyph added the

peach-web

label 2022-01-17 13:31:45 +00:00

notplants commented

2022-01-17 17:29:12 +00:00

looks great!

❤️ 1

notplants commented

2022-01-17 17:30:09 +00:00

oldschool HTML form vibe

I might want to ensure that "restore defaults" has a confirmation dialogue, or is somewhere else. Seems like it would be pretty easy to accidentally click.

oldschool HTML form vibe I might want to ensure that "restore defaults" has a confirmation dialogue, or is somewhere else. Seems like it would be pretty easy to accidentally click.

👍 1

glyph commented

2022-01-18 08:54:30 +00:00

I might want to ensure that "restore defaults" has a confirmation dialogue, or is somewhere else. Seems like it would be pretty easy to accidentally click.

That's a great idea. Perhaps clicking 'Restore Defaults' loads a second page which gives a brief word of caution about resetting the sbot config, along with buttons to 'Restore Defaults' and 'Cancel'.

> I might want to ensure that "restore defaults" has a confirmation dialogue, or is somewhere else. Seems like it would be pretty easy to accidentally click. That's a great idea. Perhaps clicking 'Restore Defaults' loads a second page which gives a brief word of caution about resetting the sbot config, along with buttons to 'Restore Defaults' and 'Cancel'.

glyph merged commit 72fbbe83f0 into main

2022-01-18 09:08:53 +00:00

glyph referenced this issue from a commit

2022-01-18 09:08:53 +00:00

Merge pull request 'Add sbot configuration route and template' (#71) from sbot_settings into main

glyph deleted branch sbot_settings

2022-01-18 09:08:54 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#71