coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve concurrency and reduce one DB call from document saving

Browse Source
This commit is contained in:
Jori Lallo
2017-07-09 20:27:06 -07:00
parent 9083f43a3e
commit 4c96f1ead0
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
server/api/documents.js
View File

@ -208,7 +208,10 @@ router.post('documents.update', auth(), async ctx => {
ctx.assertPresent(title || text, 'title or text is required'); ctx.assertPresent(title || text, 'title or text is required');
const user = ctx.state.user; const user = ctx.state.user;
const document = await Document.findById(id); const document = await Document.findById(id, {
include: ['collection'],
});
const collection = document.collection;
if (!document || document.teamId !== user.teamId) throw httpErrors.NotFound(); if (!document || document.teamId !== user.teamId) throw httpErrors.NotFound();
@ -216,16 +219,18 @@ router.post('documents.update', auth(), async ctx => {
if (title) document.title = title; if (title) document.title = title;
if (text) document.text = text; if (text) document.text = text;
document.lastModifiedById = user.id; document.lastModifiedById = user.id;
await document.save();
const collection = await Collection.findById(document.atlasId); const [updatedDocument, updatedCollection] = await Promise.all([
if (collection.type === 'atlas') { document.save(),
await collection.updateDocument(document); collection.type === 'atlas'
document.collection = collection; ? await collection.updateDocument(document)
} : Promise.resolve(),
]);
updatedDocument.collection = updatedCollection;
ctx.body = { ctx.body = {
data: await presentDocument(ctx, document), data: await presentDocument(ctx, updatedDocument),
}; };
}); });