Fixes: Loading indicator on search screen load

Fixes: Unscrollable dropdowns with large datasets
This commit is contained in:
Tom Moor
2019-04-23 07:51:02 -07:00
parent da7fdfef0a
commit a35a047cc2
2 changed files with 13 additions and 5 deletions

View File

@ -53,7 +53,10 @@ class Search extends React.Component<Props> {
componentDidMount() {
this.handleTermChange();
this.handleQueryChange();
if (this.props.location.search) {
this.handleQueryChange();
}
}
componentDidUpdate(prevProps) {

View File

@ -48,7 +48,6 @@ const FilterOptions = ({
const Content = styled('div')`
padding: 0 8px;
width: 250px;
max-height: 50vh;
p {
margin-bottom: 0;
@ -78,14 +77,20 @@ const SearchFilter = props => {
leftAlign
>
{({ closePortal }) => (
<Content>
<Scrollable>{props.children}</Scrollable>
</Content>
<MaxHeightScrollable>
<Content>{props.children}</Content>
</MaxHeightScrollable>
)}
</DropdownMenu>
);
};
const MaxHeightScrollable = styled(Scrollable)`
max-height: 50vh;
margin: -8px 0;
padding: 8px 0;
`;
const DropdownButton = styled(SearchFilter)`
margin-right: 8px;
`;