Lower Docker req to 19, make sure we test locally #115

3wordchant · 2021-03-21T13:42:03Z

3wordchant commented

2021-03-21 13:42:03 +00:00

Docker version 19.03.11, build 42e35e6

But abra works fine. So I think 19 might be sufficient?

Also, wondering if we should add DOCKER_CONTEXT=default to that check, to make sure we're not querying a remote server. (Semi-related question - should we also check remote Docker versions?)

Ref #15 ``` $ docker --version Docker version 19.03.11, build 42e35e6 ``` But `abra` works fine. So I think 19 might be sufficient? Also, wondering if we should add `DOCKER_CONTEXT=default` to that check, to make sure we're not querying a remote server. (Semi-related question - should we also check remote Docker versions?)

3wordchant added 1 commit 2021-03-21 13:42:03 +00:00

continuous-integration/drone/pr Build is passing Details

65ba113696 Lower Docker req to 19, make sure we test locally

Ref #15

``` $ docker --version
Docker version 19.03.11, build 42e35e6
```

But abra works. So I think 19 might be sufficient?

Also, wondering if we should add `DOCKER_CONTEXT=default` to that check,
to make sure we're not querying a remote server. (Semi-related question
- should we also check remote Docker versions?)

3wordchant requested review from decentral1se 2021-03-21 13:42:16 +00:00

decentral1se reviewed 2021-03-21 18:36:56 +00:00

decentral1se left a comment

Hmmmm shit, you're right actually. Now but really, thinking about it, we need to check all the daemons of all the servers or!? Like, if you have manage 5 remote docker daemons, you'd want to know they're all compatible...maybe we need to iterate through abra server ls contents and default and check them all? This could be another printf/column moment.

Hmmmm shit, you're right actually. Now but really, thinking about it, we need to check all the daemons of all the servers or!? Like, if you have manage 5 remote docker daemons, you'd want to know they're all compatible...maybe we need to iterate through `abra server ls` contents and `default` and check them all? This could be another `printf`/`column` moment.

decentral1se referenced this pull request

2021-03-22 11:45:26 +00:00

Add `abra doctor` command to check bash/docker/etc. version compat #119

decentral1se commented

2021-03-22 11:45:55 +00:00

Hmmmm shit, you're right actually. Now but really, thinking about it, we need to check all the daemons of all the servers or!? Like, if you have manage 5 remote docker daemons, you'd want to know they're all compatible...maybe we need to iterate through abra server ls contents and default and check them all? This could be another printf/column moment.

Opened https://git.autonomic.zone/coop-cloud/abra/issues/119 to continue this thought.

> Hmmmm shit, you're right actually. Now but really, thinking about it, we need to check all the daemons of all the servers or!? Like, if you have manage 5 remote docker daemons, you'd want to know they're all compatible...maybe we need to iterate through abra server ls contents and default and check them all? This could be another printf/column moment. Opened https://git.autonomic.zone/coop-cloud/abra/issues/119 to continue this thought.

decentral1se refused to review 2021-03-22 11:46:09 +00:00

decentral1se commented

2021-03-22 11:46:44 +00:00