coop-cloud/abra-test-recipe
coop-cloud/abra-test-recipe
1
0
Fork 1
generated from coop-cloud/example
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add test case for long secrets. #2

Closed
rix wants to merge 2 commits from rix/abra-integration-test-recipe:add-too-long-secret-test-case into main
pull from: rix/abra-integration-test-recipe:add-too-long-secret-test-case
merge into: coop-cloud:main
Conversation 4 Commits 2 Files Changed 2 +13
rix commented 2023-10-03 21:02:25 +00:00
Member
Copy Link

Adding test case for coop-cloud/organising#463

Adding test case for coop-cloud/organising#463
🎉 1
rix added 1 commit 2023-10-03 21:02:25 +00:00
decentral1se reviewed 2023-10-05 17:57:07 +00:00
.env.sample Outdated
@ -12,3 +12,4 @@ LETS_ENCRYPT_ENV=production
SECRET_TEST_PASS_ONE_VERSION=v1
SECRET_TEST_PASS_TWO_VERSION=v1 # length=10
#SECRET_EXTRA_PASS_VERSION=v1
#LONG_SECRET_VERSION=v1
decentral1se commented 2023-10-05 17:57:07 +00:00
Owner
Copy Link

I think it's gotta be SECRET_LONG_SECRET_VERSION where SECRET_... is included as prefix 🤔

Can't quite run over the code now tho, sorry.

I think it's gotta be `SECRET_LONG_SECRET_VERSION` where `SECRET_...` is included as prefix 🤔 Can't quite run over the code now tho, sorry.
rix commented 2023-10-10 20:49:41 +00:00
Author
Member
Copy Link

Fixed : )

Fixed : )
rix marked this conversation as resolved
decentral1se reviewed 2023-10-05 17:57:15 +00:00
decentral1se left a comment
Owner
Copy Link

🚀

🚀
decentral1se commented 2023-10-05 17:59:32 +00:00
Owner
Copy Link

@rix Feel free to merge / hack / send commits directly to main for this repo!

I'm pretty sure you have the permissions.

If you see the mess I leave in the Git log then you won't be worried to join in on the fun 😺

Merge when you're happy with it!

@rix Feel free to merge / hack / send commits directly to main for this repo! I'm pretty sure you have the permissions. If you see the mess I leave in the Git log then you won't be worried to join in on the fun 😺 Merge when you're happy with it!
rix added 1 commit 2023-10-10 20:19:03 +00:00
rix force-pushed add-too-long-secret-test-case from 09f1708a4d to 180122518f 2023-10-10 20:48:53 +00:00 Compare
rix changed title from WIP: Add test case for long secrets. to Add test case for long secrets. 2023-10-10 20:50:26 +00:00
rix changed title from Add test case for long secrets. to Add test case for long secrets. 2023-10-10 20:50:28 +00:00
rix commented 2023-10-10 20:52:12 +00:00
Author
Member
Copy Link

@rix Feel free to merge / hack / send commits directly to main for this repo!

I'm pretty sure you have the permissions.

It looks like the repo got renamed since I started working on it which caught me by surprise 😅 even after that though I don't see to have permissions to push directly to main or merge this PR so I'll need a bit of help I'm afraid. If you want to grant me the permissions then I can sort myself out if required : )

Sorry to be a pain : )

> @rix Feel free to merge / hack / send commits directly to main for this repo! > > I'm pretty sure you have the permissions. It looks like the repo got renamed since I started working on it which caught me by surprise 😅 even after that though I don't see to have permissions to push directly to main or merge this PR so I'll need a bit of help I'm afraid. If you want to grant me the permissions then I can sort myself out if required : ) Sorry to be a pain : )
decentral1se commented 2023-10-11 06:59:58 +00:00
Owner
Copy Link

Oh woops @rix, apologies, have added you! If it still doesn't work, lemme know what I can do (merge?). And yeh, bitta chaos on this repo but I think things will calm down now 🙃 Thanks for the patience.

Oh woops @rix, apologies, have added you! If it still doesn't work, lemme know what I can do (merge?). And yeh, bitta chaos on this repo but I think things will calm down now 🙃 Thanks for the patience.
decentral1se commented 2023-10-11 18:05:58 +00:00
Owner
Copy Link

Assume we can close this now?

b1c16d9c4d

👍

Assume we can close this now? https://git.coopcloud.tech/coop-cloud/abra-test-recipe/commit/b1c16d9c4dc3c7bba3cdc3def53adc343d26ca42 👍
decentral1se closed this pull request 2023-10-11 18:06:03 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra-test-recipe#2
No description provided.
Delete Branch "rix/abra-integration-test-recipe:add-too-long-secret-test-case"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?