Support more container registries #159

2022-02-20T17:13:22Z

decentral1se commented

2022-02-20 17:13:22 +00:00

This fixes also how we read the digest of the image. I think it was wrong before. Some registries restrict reading this info and we now just default to "unknown" for that case. Will need to regenerate the catalogue (have tested, it works).

This also appears to bring a wave of new dependencies due to the generic handling logic of containers/... package. The abra binary is now 1mb larger.

The catalogue generation is now slower unfortunately. But it is more robust.

The generic logic looks in ~/.docker/config.json for log in details, so you don't have to pass those in manually on the CLI anymore. We just read those defaults. You can "docker login" to get credentials setup in that file. Since most folks won't generate the catalogue, this seems fine for now. Will need to document this also.

abra recipe upgrade hedgedoc now works.

And catalogue generation for wekan is working:

➜  ./abra catalogue generate wekan
/ retrieving recipe repos list from git.coopcloud.tech... (6/-) 
WARN[0002] ensuring 1 recipe is cloned & up-to-date     
WARN[0008] unable to read digest for quay.io/wekan/wekan:v5.99 
WARN[0010] unable to read digest for quay.io/wekan/wekan:v5.98 
WARN[0025] unable to read digest for quay.io/wekan/wekan:v6.05 
WARN[0025] wekan image meta has incorrect format: [`quay.io/wekan/wekan`](https://quay.io/repository/wekan/wekan) 
INFO[0025] generated new recipe catalogue in /home/f/.abra/catalogue/recipes.json

diff --git a/recipes.json b/recipes.json
index 9b15293..b820112 100644
--- a/recipes.json
+++ b/recipes.json
@@ -2887,6 +2887,74 @@
         "versions": [],
         "website": "https://github.com/wallabag/wallabag"
     },
+    "wekan": {
+        "category": "Apps",
+        "default_branch": "main",
+        "description": "The Open Source kanban (built with Meteor).",
+        "features": {
+            "backups": "Yes",
+            "email": "Yes",
+            "healthcheck": "Yes",
+            "image": {
+                "image": "",
+                "rating": "",
+                "source": "",
+                "url": ""
+            },
+            "status": 0,
+            "tests": "?",
+            "sso": "Yes"
+        },
+        "icon": "https://git.coopcloud.tech/repo-avatars/412-072163904a9b31cb5e5e6076e20ee341",
+        "name": "wekan",
+        "repository": "https://git.coopcloud.tech/coop-cloud/wekan.git",
+        "ssh_url": "ssh://git@git.coopcloud.tech:2222/coop-cloud/wekan.git",
+        "versions": [
+            {
+                "0.1.0+v5.99": {
+                    "app": {
+                        "digest": "unknown",
+                        "image": "wekan/wekan",
+                        "tag": "v5.99"
+                    },
+                    "db": {
+                        "digest": "5285cb6",
+                        "image": "mongo",
+                        "tag": "4.4"
+                    }
+                }
+            },
+            {
+                "0.1.1+v5.98": {
+                    "app": {
+                        "digest": "unknown",
+                        "image": "wekan/wekan",
+                        "tag": "v5.98"
+                    },
+                    "db": {
+                        "digest": "5285cb6",
+                        "image": "mongo",
+                        "tag": "4.4"
+                    }
+                }
+            },
+            {
+                "0.2.0+v6.05": {
+                    "app": {
+                        "digest": "unknown",
+                        "image": "wekan/wekan",
+                        "tag": "v6.05"
+                    },
+                    "db": {
+                        "digest": "5285cb6",
+                        "image": "mongo",
+                        "tag": "4.4"
+                    }
+                }
+            }
+        ],
+        "website": ""
+    },
     "wordpress": {
         "category": "Apps",
         "default_branch": "master",

Closes https://git.coopcloud.tech/coop-cloud/organising/issues/258 This fixes also how we read the digest of the image. I think it was wrong before. Some registries restrict reading this info and we now just default to "unknown" for that case. Will need to regenerate the catalogue (have tested, it works). This also appears to bring a wave of new dependencies due to the generic handling logic of containers/... package. The abra binary is now 1mb larger. The catalogue generation is now slower unfortunately. But it is more robust. The generic logic looks in ~/.docker/config.json for log in details, so you don't have to pass those in manually on the CLI anymore. We just read those defaults. You can "docker login" to get credentials setup in that file. Since most folks won't generate the catalogue, this seems fine for now. Will need to document this also. `abra recipe upgrade hedgedoc` now works. And catalogue generation for `wekan` is working: ```bash ➜ ./abra catalogue generate wekan / retrieving recipe repos list from git.coopcloud.tech... (6/-) WARN[0002] ensuring 1 recipe is cloned & up-to-date WARN[0008] unable to read digest for quay.io/wekan/wekan:v5.99 WARN[0010] unable to read digest for quay.io/wekan/wekan:v5.98 WARN[0025] unable to read digest for quay.io/wekan/wekan:v6.05 WARN[0025] wekan image meta has incorrect format: [`quay.io/wekan/wekan`](https://quay.io/repository/wekan/wekan) INFO[0025] generated new recipe catalogue in /home/f/.abra/catalogue/recipes.json ``` ```diff diff --git a/recipes.json b/recipes.json index 9b15293..b820112 100644 --- a/recipes.json +++ b/recipes.json @@ -2887,6 +2887,74 @@ "versions": [], "website": "https://github.com/wallabag/wallabag" }, + "wekan": { + "category": "Apps", + "default_branch": "main", + "description": "The Open Source kanban (built with Meteor).", + "features": { + "backups": "Yes", + "email": "Yes", + "healthcheck": "Yes", + "image": { + "image": "", + "rating": "", + "source": "", + "url": "" + }, + "status": 0, + "tests": "?", + "sso": "Yes" + }, + "icon": "https://git.coopcloud.tech/repo-avatars/412-072163904a9b31cb5e5e6076e20ee341", + "name": "wekan", + "repository": "https://git.coopcloud.tech/coop-cloud/wekan.git", + "ssh_url": "ssh://git@git.coopcloud.tech:2222/coop-cloud/wekan.git", + "versions": [ + { + "0.1.0+v5.99": { + "app": { + "digest": "unknown", + "image": "wekan/wekan", + "tag": "v5.99" + }, + "db": { + "digest": "5285cb6", + "image": "mongo", + "tag": "4.4" + } + } + }, + { + "0.1.1+v5.98": { + "app": { + "digest": "unknown", + "image": "wekan/wekan", + "tag": "v5.98" + }, + "db": { + "digest": "5285cb6", + "image": "mongo", + "tag": "4.4" + } + } + }, + { + "0.2.0+v6.05": { + "app": { + "digest": "unknown", + "image": "wekan/wekan", + "tag": "v6.05" + }, + "db": { + "digest": "5285cb6", + "image": "mongo", + "tag": "4.4" + } + } + } + ], + "website": "" + }, "wordpress": { "category": "Apps", "default_branch": "master", ```

decentral1se changed title from ~~Support more container registries~~ to wip: support more container registries

2022-02-20 17:20:52 +00:00

decentral1se force-pushed more-registry-support from 84f5b1b74f to d7b21d886e

2022-02-20 22:46:05 +00:00

Compare

decentral1se changed title from ~~wip: support more container registries~~ to Support more container registries

2022-02-20 22:46:55 +00:00

decentral1se merged commit 598e87dca2 into main

2022-02-21 08:47:27 +00:00

decentral1se deleted branch more-registry-support

2022-02-21 08:47:58 +00:00

decentral1se referenced this pull request from toolshed/organising

2022-02-21 08:50:40 +00:00

`abra catalogue generate` chokes on non-DockerHub-hosted images #258

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#159