coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 15
Code Issues Pull Requests 4 Packages Releases 36 Activity

fix: switch back to replacing <recipe>.example.com #228

Merged
3wordchant merged 2 commits from unsmart-templating into main 2022-11-24 17:34:01 +00:00
Conversation 2 Commits 2 Files Changed 1 +4 -14
3wordchant commented 2022-11-14 15:49:58 +00:00
Owner
Copy Link

Fixes coop-cloud/organising#355

Test plan:

  1. abra app new dashy
  2. abra app config <domain>

Domain name filled in correctly!

Fixes coop-cloud/organising#355 Test plan: 1. `abra app new dashy` 2. `abra app config <domain>` Domain name filled in correctly!
3wordchant added 1 commit 2022-11-14 15:49:59 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
9927bbbea2 fix: switch back to replacing <recipe>.example.com 
Fixes #355
decentral1se reviewed 2022-11-14 16:04:23 +00:00
decentral1se left a comment
Owner
Copy Link

💯

TODO for me is to fix up this then:

grep -iR "\{ \.Domain \}" .
./hometown/.env.sample:DOMAIN={{ .Domain }}
./amusewiki/.env.sample:DOMAIN={{ .Domain }}
./rsshub/.env.sample:DOMAIN={{ .Domain }}
./traefik/.env.sample:DOMAIN={{ .Domain }}
./mycorrhiza/.env.sample:DOMAIN={{ .Domain }}
./gancio/.env.sample:DOMAIN={{ .Domain }}
./nextcloud/.env.sample:DOMAIN={{ .Domain }}
./gitea/.env.sample:DOMAIN={{ .Domain }}
💯 TODO for me is to fix up this then: ``` grep -iR "\{ \.Domain \}" . ./hometown/.env.sample:DOMAIN={{ .Domain }} ./amusewiki/.env.sample:DOMAIN={{ .Domain }} ./rsshub/.env.sample:DOMAIN={{ .Domain }} ./traefik/.env.sample:DOMAIN={{ .Domain }} ./mycorrhiza/.env.sample:DOMAIN={{ .Domain }} ./gancio/.env.sample:DOMAIN={{ .Domain }} ./nextcloud/.env.sample:DOMAIN={{ .Domain }} ./gitea/.env.sample:DOMAIN={{ .Domain }} ```
pkg/config/app.go Outdated
@ -342,1 +330,3 @@
return err
err = ioutil.WriteFile(appEnvPath, []byte(newContents), 0)
if err != nil {
panic(err)
decentral1se commented 2022-11-14 16:01:37 +00:00
Owner
Copy Link

return err

`return err`
3wordchant commented 2022-11-14 17:58:19 +00:00
Author
Owner
Copy Link

ugh thought i caught all my half-baked copypasta, fixing!

ugh thought i caught all my half-baked copypasta, fixing!
3wordchant marked this conversation as resolved
3wordchant added 1 commit 2022-11-14 17:58:56 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
ad38907a04 fix: don't panic() 😅
3wordchant commented 2022-11-14 18:01:25 +00:00
Author
Owner
Copy Link

💯

TODO for me is to fix up this then:

grep -iR "\{ \.Domain \}" .
./hometown/.env.sample:DOMAIN={{ .Domain }}
./amusewiki/.env.sample:DOMAIN={{ .Domain }}
./rsshub/.env.sample:DOMAIN={{ .Domain }}
./traefik/.env.sample:DOMAIN={{ .Domain }}
./mycorrhiza/.env.sample:DOMAIN={{ .Domain }}
./gancio/.env.sample:DOMAIN={{ .Domain }}
./nextcloud/.env.sample:DOMAIN={{ .Domain }}
./gitea/.env.sample:DOMAIN={{ .Domain }}

@decentral1se I don't mind doing that find'n'replace, up to you!

> 💯 > > TODO for me is to fix up this then: > > ``` > grep -iR "\{ \.Domain \}" . > ./hometown/.env.sample:DOMAIN={{ .Domain }} > ./amusewiki/.env.sample:DOMAIN={{ .Domain }} > ./rsshub/.env.sample:DOMAIN={{ .Domain }} > ./traefik/.env.sample:DOMAIN={{ .Domain }} > ./mycorrhiza/.env.sample:DOMAIN={{ .Domain }} > ./gancio/.env.sample:DOMAIN={{ .Domain }} > ./nextcloud/.env.sample:DOMAIN={{ .Domain }} > ./gitea/.env.sample:DOMAIN={{ .Domain }} > ``` @decentral1se I don't mind doing that find'n'replace, up to you!
decentral1se commented 2022-11-14 22:46:01 +00:00
Owner
Copy Link

@decentral1se I don't mind doing that find'n'replace, up to you!

@3wordchant that'd be amazing if you wanna sort that out, thanks!

This LGTM, merge away 🥇

> @decentral1se I don't mind doing that find'n'replace, up to you! @3wordchant that'd be amazing if you wanna sort that out, thanks! This LGTM, merge away 🥇
3wordchant merged commit a21d431541 into main 2022-11-24 17:34:01 +00:00
3wordchant deleted branch unsmart-templating 2022-11-24 17:34:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#228
No description provided.
Delete Branch "unsmart-templating"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?