Expose all env vars to app container. #263

moritz · 2023-01-31T10:25:47Z

moritz commented

2023-01-31 10:25:47 +00:00

Resolves coop-cloud/organising#393 and is required for the auto updater coop-cloud/organising#236 (comment)

Resolves https://git.coopcloud.tech/coop-cloud/organising/issues/393 and is required for the auto updater https://git.coopcloud.tech/coop-cloud/organising/issues/236#issuecomment-15390

decentral1se approved these changes 2023-01-31 13:05:19 +00:00

decentral1se left a comment

Awesome! I think we should be very loud on the release of this change to help people not get caught by the assumption that env vars should have no secrets. We want to avoid this kind of sadness for sure. I can write it up on the release documentation. Thanks!

pkg/config/app.go Outdated

						
				@ -449,1 +449,4 @@

				}

				// expose all env variables to the app container

				func ExposeAllEnv(compose *composetypes.Config, appEnv AppEnv) {

decentral1se commented

2023-01-31 13:03:41 +00:00

// ExposeAllEnv ...

```go // ExposeAllEnv ... ```

moritz marked this conversation as resolved

pkg/config/app.go Outdated

						
				@ -450,0 +452,4 @@

				func ExposeAllEnv(compose *composetypes.Config, appEnv AppEnv) {

					for _, service := range compose.Services {

						if service.Name == "app" {

							logrus.Debug("Add the following environment to the app service config:")

decentral1se commented

2023-01-31 13:04:02 +00:00

Perhaps include the app / service / etc. info in the log message? Whatever seems appropriate.

moritz marked this conversation as resolved

pkg/config/app.go Outdated

						
				@ -450,0 +458,4 @@

								if !exists {

									value := v

									service.Environment[k] = &value

									logrus.Debugf("Add Key: %s Value: %s", k, value)