add a label to signal that a deploy is a chaos deploy #265

Merged
moritz merged 2 commits from moritz/abra:chaos_label into main 2023-01-31 15:06:36 +00:00
Member

Resolves coop-cloud/organising#390 by adding the following label coop-cloud.${STACK_NAME}.chaos=true (according to the version label).
This is required for the auto updater coop-cloud/organising#236 (comment)

Resolves https://git.coopcloud.tech/coop-cloud/organising/issues/390 by adding the following label `coop-cloud.${STACK_NAME}.chaos=true` (according to the version label). This is required for the auto updater https://git.coopcloud.tech/coop-cloud/organising/issues/236#issuecomment-15390
decentral1se approved these changes 2023-01-31 13:01:58 +00:00
decentral1se left a comment
Owner

LGTM! Some small nitpicks, fix / merge as you see fit, thanks!

LGTM! Some small nitpicks, fix / merge as you see fit, thanks!
@ -449,1 +450,4 @@
}
// add a label to signal that a deploy is a chaos deploy
func SetChaosLabel(compose *composetypes.Config, stackName string, chaos bool) {
Owner

Also need to re-work the format of this like:

// SetChaosLabel adds ...
Also need to re-work the format of this like: ```go // SetChaosLabel adds ... ```
moritz marked this conversation as resolved
@ -450,0 +453,4 @@
func SetChaosLabel(compose *composetypes.Config, stackName string, chaos bool) {
for _, service := range compose.Services {
if service.Name == "app" {
logrus.Debugf("set chaos label to %s", chaos)
Owner

Perhaps including the app / recipe name would be good for debugging?

Perhaps including the app / recipe name would be good for debugging?
moritz marked this conversation as resolved
moritz force-pushed chaos_label from 36e7d936fc to c4560023d1 2023-01-31 15:05:14 +00:00 Compare
moritz added 1 commit 2023-01-31 15:05:58 +00:00
resolve PR: include the service info in the log message
Some checks failed
continuous-integration/drone/pr Build is failing
5a77ff4e55
moritz merged commit ebb86391af into main 2023-01-31 15:06:36 +00:00
moritz deleted branch chaos_label 2023-01-31 15:06:41 +00:00
Sign in to join this conversation.
No description provided.