Attempt to fix coop-cloud/organising#452 #325

rix · 2023-07-14T19:56:57Z

rix commented

2023-07-14 19:56:57 +00:00

This is my attempt to update the docker dependencies to the latest version (coop-cloud/organising#452). I've not actually worked with Go or Abra or even make files before so it's all a bit of an experiment. I've run make build and make test successfully as far as I can see it passes the tests so hopefully that's good enough. Let me know if there are further tests I should be doing to check everything is working ok : )

This is my attempt to update the docker dependencies to the latest version (https://git.coopcloud.tech/coop-cloud/organising/issues/452). I've not actually worked with Go or Abra or even make files before so it's all a bit of an experiment. I've run make build and make test successfully as far as I can see it passes the tests so hopefully that's good enough. Let me know if there are further tests I should be doing to check everything is working ok : )

❤️ 1

rix added 5 commits 2023-07-14 19:56:58 +00:00

383f2afba7 Add docker v24 and associated dependencies.

a340a65630 Replace types.volume with new volume type

f4bdb8390a Change CommonOptions (deprecated) to ClientOptions and remove unneeded parameters.

bab8f41070 Update volume list options.

continuous-integration/drone/pr Build is failing Details

e362926771 Replace deprecated system.TempFileSequential with os.CreateTemp

rix added 1 commit 2023-07-14 20:11:51 +00:00

continuous-integration/drone/pr Build is passing Details

7668fcba57 Fix formatting.

decentral1se reviewed 2023-07-15 07:57:21 +00:00

decentral1se left a comment

Incredible work @rix! Thanks for working on this, really appreciate the help on these tricky maintenance tasks. LGTM. Since we have few tests, it'd be good to manually tests the affected commands. That seems to be abra app backup, abra app remove. Can help with that if you're happy with this, we can just merge it.

Incredible work @rix! Thanks for working on this, really appreciate the help on these tricky maintenance tasks. LGTM. Since we have few tests, it'd be good to manually tests the affected commands. That seems to be `abra app backup`, `abra app remove`. Can help with that if you're happy with this, we can just merge it.

❤️ 1

rix changed title from ~~WIP: Attempt to fix coop-cloud/organising#452~~ to Attempt to fix coop-cloud/organising#452

2023-07-15 08:09:14 +00:00

decentral1se merged commit a7ce71d6cf into main

2023-07-15 08:15:53 +00:00

Sign in to join this conversation.

No reviewers