coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 15
Code Issues Pull Requests 4 Packages Releases 36 Activity

generate secrets from config #356

Merged
decentral1se merged 3 commits from fix-secret-generation into main 2023-09-25 08:34:09 +00:00
Conversation 0 Commits 3 Files Changed 14 +579 -282
decentral1se commented 2023-09-24 10:33:56 +00:00
Owner
Copy Link

We won't read the .env file for secret names anymore, we'll read them from the recipe config. This is more consistent as pointed out in coop-cloud/organising#464. Here's what still needs implementing:

  • We should read version numbers from the .env of the app, not the .env.sample
  • If no version is set in the .env of the app & it is in the recipe config, warn we can't generate
  • Filter loaded compose files by COMPOSE_FILE so we don't generate unwanted secrets
  • Tests
We won't read the `.env` file for secret names anymore, we'll read them from the recipe config. This is more consistent as pointed out in https://git.coopcloud.tech/coop-cloud/organising/issues/464. Here's what still needs implementing: - We should read version numbers from the `.env` of the app, not the `.env.sample` - If no version is set in the `.env` of the app & it is in the recipe config, warn we can't generate - Filter loaded compose files by `COMPOSE_FILE` so we don't generate unwanted secrets - Tests
decentral1se added 1 commit 2023-09-24 10:34:05 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
3d2e307892
WIP: generate secrets from config 
See coop-cloud/organising#464
decentral1se force-pushed fix-secret-generation from 3d2e307892 to d49bf7735d 2023-09-24 22:58:25 +00:00 Compare
decentral1se force-pushed fix-secret-generation from d49bf7735d to c065ceb1f0 2023-09-25 08:33:40 +00:00 Compare
decentral1se changed title from WIP: generate secrets from config to generate secrets from config 2023-09-25 08:33:45 +00:00
decentral1se merged commit c065ceb1f0 into main 2023-09-25 08:34:09 +00:00
decentral1se deleted branch fix-secret-generation 2023-09-25 08:34:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#356
No description provided.
Delete Branch "fix-secret-generation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?