coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 14
Code Issues Pull Requests 4 Packages Releases 36 Activity

Preliminary makefile support for building inside docker #384

Manually merged
decentral1se merged 2 commits from cr_dockerinside into main 2023-11-27 10:17:28 +00:00
Conversation 2 Commits 2 Files Changed 2 +23
cas commented 2023-11-09 18:52:48 +00:00
Owner
Copy Link

Just streamlines building with docker and the upstream golang container of appropriate version.

Just streamlines building with docker and the upstream golang container of appropriate version.
❤️ 1
cas added 1 commit 2023-11-09 18:52:49 +00:00
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
1d098eed0e Preliminary makefile support for building inside docker
cas added 1 commit 2023-11-09 19:14:48 +00:00
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
20a7cffb71 Fix errors in build-docker-inside.sh
3wordchant commented 2023-11-10 14:36:26 +00:00
Owner
Copy Link

I had to add :z to the volume spec to appease SELinux, does this cause any porblems on non-SELinux systems?

I had to add `:z` to the volume spec to appease SELinux, does this cause any porblems on non-SELinux systems?
p4u1 reviewed 2023-11-12 15:04:43 +00:00
build-docker-inside.sh
@ -0,0 +6,4 @@
fi
git config --global --add safe.directory /abra # work around funky file permissions
# fixme for some reason we need to do this
p4u1 commented 2023-11-12 15:04:43 +00:00
Member
Copy Link

I probably go the same error locally. Running go mod tidy fixed this for me (see #387)

I probably go the same error locally. Running `go mod tidy` fixed this for me (see https://git.coopcloud.tech/coop-cloud/abra/pulls/387)
👍 1
decentral1se marked this conversation as resolved
decentral1se approved these changes 2023-11-27 10:17:20 +00:00
decentral1se left a comment
Owner
Copy Link

👏

👏
decentral1se manually merged commit 31e0ed75b0 into main 2023-11-27 10:17:28 +00:00
decentral1se commented 2023-11-27 10:18:12 +00:00
Owner
Copy Link

Hope you don't mind, I tucked the script into the scripts/ dir. Tested the build and it seems to work. Maybe we can create a separate target to deal with #384 (comment)? Unsure. Can review/merge whatever else comes up.

Hope you don't mind, I tucked the script into the `scripts/` dir. Tested the build and it seems to work. Maybe we can create a separate target to deal with https://git.coopcloud.tech/coop-cloud/abra/pulls/384#issuecomment-18823? Unsure. Can review/merge whatever else comes up.
Sign in to join this conversation.
Reviewers
No reviewers
decentral1se
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#384
No description provided.
Delete Branch "cr_dockerinside"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?