coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 15
Code Issues Pull Requests 4 Packages Releases 36 Activity

Fix ls -S to deal with broken/unparsable app versions more correctly #385

Closed
cas wants to merge 2 commits from cr_fix_ls-S into cr_dockerinside
pull from: cr_fix_ls-S
merge into: coop-cloud:cr_dockerinside
Conversation 1 Commits 2 Files Changed 1 +15 -12
cas commented 2023-11-09 18:54:21 +00:00
Owner
Copy Link

Fix error handling inside abra app ls -S so that it outputs competent / useful output even if versions can't be parsed.

[is a branch from cr_dockerinside, so merge afterwards]

Fix error handling inside `abra app ls -S` so that it outputs competent / useful output even if versions can't be parsed. [is a branch from cr_dockerinside, so merge afterwards]
❤️ 2
cas added 1 commit 2023-11-09 18:54:21 +00:00
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
3939971d82 Fix ls -S to deal with broken/unparsable app versions more correctly
cas added 1 commit 2023-11-09 19:14:27 +00:00
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is failing Details
d041deec68 Better logical layout for app ls -S
decentral1se reviewed 2023-11-27 10:26:32 +00:00
cli/app/list.go
@ -182,3 +179,2 @@
logrus.Fatal(err)
}
if (version != "unknown") {
decentral1se commented 2023-11-27 10:26:32 +00:00
Owner
Copy Link

(...) not required?

`(...)` not required?
decentral1se reviewed 2023-11-27 10:27:13 +00:00
decentral1se left a comment
Owner
Copy Link

Thanks! Would it be possible to get a test for this one? Or if you're confident to merge as-is, please go for it! Not sure how to test this myself right now.

Thanks! Would it be possible to get a test for this one? Or if you're confident to merge as-is, please go for it! Not sure how to test this myself right now.
decentral1se closed this pull request 2024-03-11 13:04:39 +00:00
decentral1se commented 2024-03-11 13:07:27 +00:00
Owner
Copy Link

Oh dear dog I accidentally deleted the branch for this, I'm sorry 😱 Have you still got a copy @cas?

Oh dear dog I accidentally deleted the branch for this, I'm sorry 😱 Have you still got a copy @cas?
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#385
No description provided.
Delete Branch "cr_fix_ls-S"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?