proper env modifiers support #391
No reviewers
Labels
No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/abra#391
Loading…
Reference in New Issue
No description provided.
Delete Branch "p4u1/abra:env-modifiers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This implements proper modifier support in the env file using this new fork of the
godotenv
library. The modifier implementation is quite basic for but can be improved later if needed. See this commit for the actual implementation.Because we are now using proper modifer parsing, it does not affect the parsing of value, so this is possible again:
Closes coop-cloud/organising#535
WIP: env modifiersto env modifiersenv modifiersto WIP: env modifiers899909b2ed
tod09aedb5fe
As noted in chat, maybe it's better to not inline the library, but instead fork the library into the coopcloud organization and add my patch there. Then it would be easier to apply upstream patches.
Edit: I created the fork instead of copying the files here
d09aedb5fe
to574e0b257b
WIP: env modifiersto proper env modifiers support@ -83,1 +79,3 @@
return secretConfigs, err
return nil, err
}
configWithoutEnv, err := loader.LoadComposefile(opts, map[string]string{}, loader.SkipInterpolation)
@decentral1se This is how I get the raw compose file. The secret
Name
will then be like this:I need this, to properly map the secretId to the secret version env var where the modifer is defined.
This might help you with coop-cloud/organising#464
6c3863668e
toea0c052c1e
Looking great @p4u1, i'm merging this 💯