feat: abra release now asks for a release note #393

Merged
p4u1 merged 1 commits from p4u1/abra:recipe-release-release-note into main 2023-12-12 14:46:21 +00:00
Member

This implements coop-cloud/organising#540 by checking if arelease/next file exists and if so moves it to release/<tag>. When no release notes exists it prompts for them.

This implements https://git.coopcloud.tech/coop-cloud/organising/issues/540 by checking if a`release/next` file exists and if so moves it to `release/<tag>`. When no release notes exists it prompts for them.
p4u1 added 1 commit 2023-12-04 10:34:51 +00:00
continuous-integration/drone/pr Build is failing Details
9390f66b22
feat: abra release now asks for a release note
Before asking for a release note, it checks if release/next exists and
copies it to release/<tag>.
p4u1 requested review from 3wordchant 2023-12-04 10:35:30 +00:00
p4u1 requested review from moritz 2023-12-04 10:35:30 +00:00
p4u1 force-pushed recipe-release-release-note from 9390f66b22 to ced1676240 2023-12-04 10:38:09 +00:00 Compare
decentral1se reviewed 2023-12-04 17:34:06 +00:00
@ -106,0 +126,4 @@
run git -C "$ABRA_DIR/recipes/$TEST_RECIPE" config --local user.name test
assert_success
run bash -c "echo 'those are some release notes for the next release' >> $ABRA_DIR/recipes/$TEST_RECIPE/release/next"
Owner

Think you need a assert_success per command to check that all don't fail?

Think you need a `assert_success` per command to check that all don't fail?
Author
Member

Good catch! I added the missing assert and also refactored the integration tests some more.

Good catch! I added the missing assert and also refactored the integration tests some more.
decentral1se marked this conversation as resolved
decentral1se reviewed 2023-12-04 17:35:00 +00:00
decentral1se left a comment
Owner

Looking solid! I think it would be good to try find somewhere on https://docs.coopcloud.tech to mention this. It's a bit of a mess there, but anywhere will do. Only one minor comment, merge whenever you're happy with it! Thanks!

Looking solid! I think it would be good to try find somewhere on https://docs.coopcloud.tech to mention this. It's a bit of a mess there, but anywhere will do. Only one minor comment, merge whenever you're happy with it! Thanks!
p4u1 reviewed 2023-12-04 18:54:32 +00:00
@ -240,0 +262,4 @@
logrus.Debugf("dry run: move release note from 'next' to %s", tag)
return nil
}
err := os.Rename(nextReleaseNotePath, tagReleaseNotePath)
Author
Member

Maybe we should ask the user with a prompt before doing the rename?

Something like "Relase notes were detected in release/next. Do You want to use them for this release?"

Maybe we should ask the user with a prompt before doing the rename? Something like "Relase notes were detected in release/next. Do You want to use them for this release?"
Owner

Yeh, that does sound less magic and more explicit. Nice.

Yeh, that does sound less magic and more explicit. Nice.
decentral1se marked this conversation as resolved
p4u1 force-pushed recipe-release-release-note from ced1676240 to 411c0c138c 2023-12-04 19:12:48 +00:00 Compare
p4u1 force-pushed recipe-release-release-note from 411c0c138c to f302145a1c 2023-12-04 22:36:03 +00:00 Compare
p4u1 force-pushed recipe-release-release-note from f302145a1c to fd6c5b3b6d 2023-12-05 20:50:45 +00:00 Compare
p4u1 force-pushed recipe-release-release-note from fd6c5b3b6d to efb935b02b 2023-12-05 20:51:46 +00:00 Compare
moritz approved these changes 2023-12-07 16:11:10 +00:00
decentral1se reviewed 2023-12-08 08:38:17 +00:00
decentral1se left a comment
Owner

Merge away 💣

Merge away 💣
p4u1 merged commit af8cd1f67a into main 2023-12-12 14:46:21 +00:00
p4u1 deleted branch recipe-release-release-note 2023-12-12 14:46:21 +00:00
Author
Member

@decentral1se Merged and proposed doc changes here: coop-cloud/docs.coopcloud.tech#244

@decentral1se Merged and proposed doc changes here: https://git.coopcloud.tech/coop-cloud/docs.coopcloud.tech/pulls/244
Sign in to join this conversation.
No description provided.