fix: secret name generation when secretId is not part of the secret name #394

p4u1 · 2023-12-04T13:40:26Z

p4u1 commented

2023-12-04 13:40:26 +00:00

After working on the env var modifiers I was bit familiar with the secret generation code and after talking to @decentral1se I tried to fix the remaining secret generation issue.

This should fix the remaining bug in coop-cloud/organising#464

@moritz and @decentral1se can you check if this is the correct behaviour for secrets now?

After working on the env var modifiers I was bit familiar with the secret generation code and after talking to @decentral1se I tried to fix the remaining secret generation issue. This should fix the remaining bug in https://git.coopcloud.tech/coop-cloud/organising/issues/464 @moritz and @decentral1se can you check if this is the correct behaviour for secrets now?

p4u1 added 1 commit 2023-12-04 13:40:26 +00:00

continuous-integration/drone/pr Build is passing Details

964d4efca4 fix: secret name generation when secretId is not part of the secret name

p4u1 reviewed 2023-12-04 13:41:33 +00:00

pkg/secret/secret_test.go

						
				@ -40,2 +26,2 @@

						assert.Contains(t, secretsFromConfig, secretId)

					}

					// Secret name does not include the secret id

					assert.Equal(t, "test_example_com_pass_three_v2", secretsFromConfig["test_pass_three"].RemoteName)

p4u1 commented

2023-12-04 13:41:33 +00:00

This is where I tested the remote name is correct, when the secret id is not part of the secret name.

decentral1se reviewed 2023-12-04 17:37:45 +00:00

decentral1se left a comment

Wow, you're a hero @p4u1 😲

This is looking really solid. Tysm for working on it.

I had only had time for a quick review.

Hoping @moritz can also take a look ASAP.

Wow, you're a hero @p4u1 😲 This is looking really solid. Tysm for working on it. I had only had time for a quick review. Hoping @moritz can also take a look ASAP.

decentral1se commented

2023-12-04 21:52:02 +00:00