WIP: minor improvements #397
No reviewers
Labels
No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/abra#397
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "wykwit/abra:minor-improvements"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Minor improvements to make things easier to understand and make the
staticcheck
slightly less sad.LGTM @wykwit, thanks! Merge when you're happy with it 💘
@ -6,4 +6,3 @@
"coopcloud.tech/abra/pkg/config"
"coopcloud.tech/abra/pkg/formatter"
"coopcloud.tech/abra/pkg/recipe"
recipePkg "coopcloud.tech/abra/pkg/recipe"
I think
"coopcloud.tech/abra/pkg/recipe"
should be the preferd way to import the package. Or is there a specific reason why you changed the import everywhere?I changed it wherever there was a double import, because in some places
recipe
can either be a variable or a package. It was used inconsistently within those source files, referring to the package sometimes asrecipePkg
and sometimes as justrecipe
which is additionally confusing whenrecipe
is also used there as a common variable name. There are still some other places where the import is not renamed, but when the package name gets overshadowed it's not used anymore.Added a comment about the import path, otherwise LGTM :)
@wykwit got any cycles to take another run at this?
Minor improvementsto WIP: minor improvementsGonna close off due to inactivity.
Pull request closed