WIP: minor improvements #397

Closed
wykwit wants to merge 7 commits from wykwit/abra:minor-improvements into main
Member

Minor improvements to make things easier to understand and make the staticcheck slightly less sad.

Minor improvements to make things easier to understand and make the `staticcheck` slightly less sad.
wykwit added 7 commits 2024-01-06 01:25:03 +00:00
decentral1se approved these changes 2024-01-06 09:12:54 +00:00
decentral1se left a comment
Owner

LGTM @wykwit, thanks! Merge when you're happy with it 💘

LGTM @wykwit, thanks! Merge when you're happy with it 💘
p4u1 reviewed 2024-01-06 15:57:31 +00:00
@ -6,4 +6,3 @@
"coopcloud.tech/abra/pkg/config"
"coopcloud.tech/abra/pkg/formatter"
"coopcloud.tech/abra/pkg/recipe"
recipePkg "coopcloud.tech/abra/pkg/recipe"
Member

I think "coopcloud.tech/abra/pkg/recipe" should be the preferd way to import the package. Or is there a specific reason why you changed the import everywhere?

I think `"coopcloud.tech/abra/pkg/recipe"` should be the preferd way to import the package. Or is there a specific reason why you changed the import everywhere?
Author
Member

I changed it wherever there was a double import, because in some places recipe can either be a variable or a package. It was used inconsistently within those source files, referring to the package sometimes as recipePkg and sometimes as just recipe which is additionally confusing when recipe is also used there as a common variable name. There are still some other places where the import is not renamed, but when the package name gets overshadowed it's not used anymore.

I changed it wherever there was a double import, because in some places `recipe` can either be a variable or a package. It was used inconsistently within those source files, referring to the package sometimes as `recipePkg` and sometimes as just `recipe` which is additionally confusing when `recipe` is also used there as a common variable name. There are still some other places where the import is not renamed, but when the package name gets overshadowed it's not used anymore.
p4u1 approved these changes 2024-01-06 15:58:03 +00:00
p4u1 left a comment
Member

Added a comment about the import path, otherwise LGTM :)

Added a comment about the import path, otherwise LGTM :)
Owner

@wykwit got any cycles to take another run at this?

@wykwit got any cycles to take another run at this?
decentral1se changed title from Minor improvements to WIP: minor improvements 2024-03-27 05:43:08 +00:00
Owner

Gonna close off due to inactivity.

Gonna close off due to inactivity.
decentral1se closed this pull request 2024-06-24 22:08:49 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing

Pull request closed

Sign in to join this conversation.
No description provided.