WIP: minor improvements #397

Draft

wykwit wants to merge 7 commits from wykwit/abra:minor-improvements into main

wykwit commented

2024-01-06 01:25:03 +00:00

Member

Minor improvements to make things easier to understand and make the staticcheck slightly less sad.

Minor improvements to make things easier to understand and make the `staticcheck` slightly less sad.

wykwit added 7 commits 2024-01-06 01:25:03 +00:00

108456585d chore: use keyed fields with struct literals

39c531b9e8 chore: list upgrade sources in cmd help

3fd249b0d8 fix: display text next to emojis in app check cmd

192d430039 chore: use recipePkg import consistently

0c4d5b2e69 chore: use Printf() instead of Println(Sprintf())

700e951e5e chore: remove unneccessary call to Sprintf

continuous-integration/drone/pr Build is passing Details

d3022c27ea chore: change NewAppServerFlag usage description

decentral1se approved these changes 2024-01-06 09:12:54 +00:00

decentral1se left a comment

Owner

LGTM @wykwit, thanks! Merge when you're happy with it 💘

LGTM @wykwit, thanks! Merge when you're happy with it 💘

p4u1 reviewed 2024-01-06 15:57:31 +00:00

cli/app/check.go

						
				@ -6,4 +6,3 @@

					"coopcloud.tech/abra/pkg/config"

					"coopcloud.tech/abra/pkg/formatter"

					"coopcloud.tech/abra/pkg/recipe"

					recipePkg "coopcloud.tech/abra/pkg/recipe"

p4u1 commented

2024-01-06 15:57:03 +00:00

Member

I think "coopcloud.tech/abra/pkg/recipe" should be the preferd way to import the package. Or is there a specific reason why you changed the import everywhere?

I think `"coopcloud.tech/abra/pkg/recipe"` should be the preferd way to import the package. Or is there a specific reason why you changed the import everywhere?

wykwit commented

2024-01-06 16:17:32 +00:00

Author

Member

I changed it wherever there was a double import, because in some places recipe can either be a variable or a package. It was used inconsistently within those source files, referring to the package sometimes as recipePkg and sometimes as just recipe which is additionally confusing when recipe is also used there as a common variable name. There are still some other places where the import is not renamed, but when the package name gets overshadowed it's not used anymore.

I changed it wherever there was a double import, because in some places `recipe` can either be a variable or a package. It was used inconsistently within those source files, referring to the package sometimes as `recipePkg` and sometimes as just `recipe` which is additionally confusing when `recipe` is also used there as a common variable name. There are still some other places where the import is not renamed, but when the package name gets overshadowed it's not used anymore.

p4u1 approved these changes 2024-01-06 15:58:03 +00:00

p4u1 left a comment

Member

Added a comment about the import path, otherwise LGTM :)

Added a comment about the import path, otherwise LGTM :)

decentral1se commented

2024-03-27 05:41:38 +00:00

Owner

@wykwit got any cycles to take another run at this?

@wykwit got any cycles to take another run at this?

decentral1se changed title from ~~Minor improvements~~ to WIP: minor improvements

2024-03-27 05:43:08 +00:00

continuous-integration/drone/pr Build is passing

Details

This pull request has changes conflicting with the target branch.

cli/app/remove.go
cli/app/restore.go
pkg/client/volumes.go
pkg/lint/recipe.go

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b wykwit-minor-improvements main

git pull minor-improvements

Step 2:

Merge the changes and update on Gitea.

git checkout main

git merge --no-ff wykwit-minor-improvements

git push origin main

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#397

No description provided.