WIP: untie server name from a domain #398

wykwit · 2024-01-06T01:36:41Z

wykwit commented

2024-01-06 01:36:41 +00:00

The convention of mapping names to domains was driving me crazy.

This fix resolves the actual server hostname according to host entry in the SSH config, allows for using any server name, but most importantly allows for adding local machines as servers.
Turns out that's enough to use abra for LAN-only deployments.

Default behaviors shouldn't change.

The convention of mapping names to domains was driving me crazy. This fix resolves the actual server hostname according to host entry in the SSH config, allows for using any server name, but most importantly allows for adding local machines as servers. Turns out that's enough to use `abra` for LAN-only deployments. Default behaviors shouldn't change.

wykwit added 2 commits 2024-01-06 01:36:41 +00:00

5d503319e3 feat: untie server name from a domain in the add command

continuous-integration/drone/pr Build is passing Details

fd15aeab9a fix: make dns resolve errors more accurate

decentral1se reviewed 2024-01-06 09:18:00 +00:00

decentral1se left a comment

Solid stuff! One minor comment.

I think it'd be nice if you could add an integration test for this?

Solid stuff! One minor comment. I think it'd be nice if you could add an integration test for this?

👍 1

cli/server/add.go Outdated

						
				@ -169,1 +175,4 @@

						if err := newContext(c, domainName, hostConfig.Host, hostConfig.User, hostConfig.Port); err != nil {

							logrus.Fatal(err)

							cleanUp(domainName)