toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

feat: add git-user and git-email flags to recipe new #405

Merged
decentral1se merged 1 commits from p4u1/abra:recipe-init-git-user into main 2024-06-22 16:38:32 +00:00
Conversation 5 Commits 1 Files Changed 4 +37 -14
p4u1 commented 2024-03-07 16:47:21 +00:00
Member
Copy Link
No description provided.
🚀 1
p4u1 force-pushed recipe-init-git-user from 71859f0b76 to 074fbb7613 2024-03-07 16:48:32 +00:00 Compare
p4u1 changed title from recipe-init-git-user to feat: add git-user and git-email flags to recipe new 2024-03-07 17:01:28 +00:00
decentral1se approved these changes 2024-03-08 07:41:08 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM, thanks!

LGTM, thanks!
p4u1 commented 2024-03-08 08:42:41 +00:00
Author
Member
Copy Link

If we merge this I think I want to rename the --git-user flag to --git-name to be more aligned with git naming

If we merge this I think I want to rename the --git-user flag to --git-name to be more aligned with git naming
decentral1se commented 2024-03-27 05:45:18 +00:00
Owner
Copy Link

@p4u1 yeh let's do coop-cloud/abra#405 (comment) and merge no? Looks like a solid change that'd be particularly useful for CI/CD envirnonments / automation also...

@p4u1 yeh let's do https://git.coopcloud.tech/coop-cloud/abra/pulls/405#issuecomment-19842 and merge no? Looks like a solid change that'd be particularly useful for CI/CD envirnonments / automation also...
decentral1se changed title from feat: add git-user and git-email flags to recipe new to WIP: feat: add git-user and git-email flags to recipe new 2024-03-27 05:45:29 +00:00
p4u1 force-pushed recipe-init-git-user from 074fbb7613 to 30bb8059e2 2024-06-22 15:35:03 +00:00 Compare
p4u1 force-pushed recipe-init-git-user from 30bb8059e2 to c23d2d34b9 2024-06-22 15:36:36 +00:00 Compare
p4u1 commented 2024-06-22 15:36:55 +00:00
Author
Member
Copy Link

@decentral1se finally pushed an update, should be good to go now :)

@decentral1se finally pushed an update, should be good to go now :)
decentral1se approved these changes 2024-06-22 16:38:16 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM!

LGTM!
tests/integration/recipe_new.bats
@ -24,3 +24,3 @@
@test "create new recipe" {
run $ABRA recipe new foobar
run $ABRA recipe new foobar --git-name foo --git-email foo@example.com
decentral1se commented 2024-06-22 16:37:09 +00:00
Owner
Copy Link

I think I'd prefer to have a specific test which uses name/email and a check. And then we keep these tests which cover the basic funcionality without the flags. I'll sort that out in a follow-up commit 👍

I think I'd prefer to have a specific test which uses name/email and a check. And then we keep these tests which cover the basic funcionality without the flags. I'll sort that out in a follow-up commit 👍
decentral1se changed title from WIP: feat: add git-user and git-email flags to recipe new to feat: add git-user and git-email flags to recipe new 2024-06-22 16:38:24 +00:00
decentral1se merged commit b2485cc122 into main 2024-06-22 16:38:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#405
No description provided.
Delete Branch "p4u1/abra:recipe-init-git-user"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?