coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 15
Code Issues Pull Requests 4 Packages Releases 36 Activity

fix: add missing packages on final layer #407

Merged
decentral1se merged 1 commits from tls-docker into main 2024-04-01 11:58:19 +00:00
Conversation 0 Commits 1 Files Changed 1 +10 -4
decentral1se commented 2024-03-31 00:41:36 +00:00
Owner
Copy Link

So, this scratch image is too "scratch" and we can just use alpine and update certs on the final layer also to ensure we avoid old cert files. Also, the release logic now requires a dependency on git for showing diffs. Also, I abra routinely calls /usr/bin/ssh, so added that also. This should make it more functional. Manually tested and the error goes away. Closes coop-cloud/organising#598.

So, this `scratch` image is too "scratch" and we can just use `alpine` and update certs on the final layer also to ensure we avoid old cert files. Also, the release logic now requires a dependency on `git` for showing diffs. Also, I `abra` routinely calls `/usr/bin/ssh`, so added that also. This should make it more functional. Manually tested and the error goes away. Closes https://git.coopcloud.tech/coop-cloud/organising/issues/598.
❤️ 1
decentral1se added 1 commit 2024-03-31 00:41:36 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
a0d70a14f4
fix: add missing packages on final layer 
Closes coop-cloud/organising#598
decentral1se requested review from 3wordchant 2024-03-31 00:41:54 +00:00
decentral1se force-pushed tls-docker from a0d70a14f4 to 2ecace3e90 2024-04-01 11:58:03 +00:00 Compare
decentral1se merged commit 2ecace3e90 into main 2024-04-01 11:58:19 +00:00
decentral1se deleted branch tls-docker 2024-04-01 11:58:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
3wordchant
Labels
Clear labels   
bug

Something is not working

  
build

go build related issues

  
ci/cd

Building things with CI/CD

  
contributing

Dealing with contributing

  
design

UI/UX

  
documentation

Documenting all the things

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

relating to the project or repo itself

  
question

More information is needed

  
security

Security related

  
wontfix

This won't be fixed

No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#407
No description provided.
Delete Branch "tls-docker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?