test: use more plumbing for git output #414

decentral1se · 2024-06-20T09:09:12Z

decentral1se commented

2024-06-20 09:09:12 +00:00

Aight, I think I've got a way we can compare Git checkouts/hashes/tags etc. without relying on end-user facing Git output ("porcelain") which is changing. We need to use more "plumbing" commands to get reliable output in the future.

Tested on app_new.bats with success!

Working on coop-cloud/organising#595 coop-cloud/organising#584

cc @p4u1

Aight, I think I've got a way we can compare Git checkouts/hashes/tags etc. without relying on end-user facing Git output ("porcelain") which is changing. We need to use more "plumbing" commands to get reliable output in the future. Tested on `app_new.bats` with success! Working on https://git.coopcloud.tech/coop-cloud/organising/issues/595 https://git.coopcloud.tech/coop-cloud/organising/issues/584 cc @p4u1

❤️ 2

decentral1se added 1 commit 2024-06-20 09:09:12 +00:00

test: use more plumbung for git output

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

302c88e5d2

decentral1se referenced this pull request

2024-06-20 09:10:26 +00:00

fix: abra app new checks out latest version #412

decentral1se changed title from ~~test: use more plumbung for git output~~ to test: use more plumbing for git output

2024-06-20 13:03:35 +00:00

p4u1 commented

2024-06-20 21:05:44 +00:00

Nice,I think this is going in the right direction! Did you consider returning a value in those got helper functions instead of setting env variables? This seems a little magic for me

👍 1

decentral1se force-pushed git-plumbing-approach from 302c88e5d2 to 43990b6fae

2024-06-21 15:11:00 +00:00

Compare

decentral1se commented

2024-06-21 15:15:40 +00:00

Nice,I think this is going in the right direction! Did you consider returning a value in those got helper functions instead of setting env variables? This seems a little magic for me

Agreed but sadly, Bash is wild and return is not "return" 😱 Instead of export ... I set a var now 😬

> Nice,I think this is going in the right direction! Did you consider returning a value in those got helper functions instead of setting env variables? This seems a little magic for me Agreed but sadly, Bash is *wild* and `return` is not "return" 😱 Instead of `export ...` I set a var now 😬

decentral1se merged commit 43990b6fae into main

2024-06-21 15:16:18 +00:00

decentral1se deleted branch git-plumbing-approach

2024-06-21 15:16:18 +00:00

3wordchant commented

2024-06-23 16:33:44 +00:00

return only works with numeric codes, I think, $historical_reasons.

`return` only works with numeric codes, I think, `$historical_reasons`.

👍 1

Sign in to join this conversation.

No reviewers