toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix: abra app new checks out latest version #412

Merged
decentral1se merged 1 commits from new-deploy-checkout into main 2024-06-21 13:54:10 +00:00
Conversation 3 Commits 1 Files Changed 4 +42 -5
decentral1se commented 2024-06-20 06:43:58 +00:00
Owner
Copy Link

See coop-cloud/organising#618

I've also manually tested that recipes without versions still work 👌

See https://git.coopcloud.tech/coop-cloud/organising/issues/618 I've also manually tested that recipes without versions still work 👌
decentral1se requested review from iexos 2024-06-20 06:44:08 +00:00
decentral1se reviewed 2024-06-20 09:10:26 +00:00
tests/integration/app_new.bats Outdated
@ -37,6 +37,15 @@ teardown(){
}
@test "create new app" {
_fetch_recipe
decentral1se commented 2024-06-20 09:10:26 +00:00
Author
Owner
Copy Link

Better approach in coop-cloud/abra#414! Will merge this as-is and rebase this new PR on top of the changes in that PR. Looks like things are coming together for not having constantly broken integration tests...

Better approach in https://git.coopcloud.tech/coop-cloud/abra/pulls/414! Will merge this as-is and rebase this new PR on top of the changes in that PR. Looks like things are coming together for not having constantly broken integration tests...
decentral1se marked this conversation as resolved
iexos refused to review 2024-06-20 14:23:56 +00:00
iexos commented 2024-06-20 14:25:18 +00:00
First-time contributor
Copy Link

Sorry, cannot really review this. Im not familiar with the codebase or even go, and haven't even built abra from source yet

Sorry, cannot really review this. Im not familiar with the codebase or even go, and haven't even built abra from source yet
👍 1
p4u1 reviewed 2024-06-20 21:15:22 +00:00
cli/app/new.go Outdated
@ -82,2 +84,4 @@
logrus.Fatal(err)
}
if len(recipeVersions) > 0 {
p4u1 commented 2024-06-20 21:15:22 +00:00
Member
Copy Link

Can you add a comment (above) this if statement explaing this case and the block inside? It not quite clear to me by just reading the code

Can you add a comment (above) this if statement explaing this case and the block inside? It not quite clear to me by just reading the code
👍 1
decentral1se marked this conversation as resolved
decentral1se force-pushed new-deploy-checkout from c471b5876d to 316fdd3643 2024-06-21 13:53:34 +00:00 Compare
decentral1se merged commit 316fdd3643 into main 2024-06-21 13:54:10 +00:00
decentral1se deleted branch new-deploy-checkout 2024-06-21 13:54:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#412
No description provided.
Delete Branch "new-deploy-checkout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?