fix: abra app rm trying to remove secrets twice #50
No reviewers
Labels
No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/abra#50
Loading…
Reference in New Issue
No description provided.
Delete Branch "knoflook/abra:main"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
9da1108150
toc9d5e8f6cc
LGTM
(idk if our convention here is
var foo []string
orfoo := []string{}
, @roxxers got a nugget of wisdom for us?)Fix trying to remove secrets twiceto fix: abra app rm trying to remove secrets twiceit looks like the convention is
var name []string
indeedvar foo []string
is way better initalising an empty version of a type. The latter is like technically fine but I really only like using it when actually defining items in the struct or slice.Edit: looking into the actual differences between these methods, the former means we don't actually need to initalise the data in the type while the latter forces that. So yeah I'd prefer the former unless we had data already to input.
https://www.geeksforgeeks.org/difference-between-var-keyword-and-short-declaration-operator-in-golang/
So does that mean it's good for merging?
c9d5e8f6cc
to4b0168139d
4b0168139d
to4910914c2d
4910914c2d
tofde9fe1c1f
fde9fe1c1f
tocefad74e22