backup multiple paths #5
No reviewers
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/backup-bot-two#5
Loading…
Reference in New Issue
No description provided.
Delete Branch "multi_path"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
still a wip because I'm still trying to understand the
docker cp
behaviour.okay got my head around it:
docker cp
has different behaviour if the DEST path already exists and there is a/.
or/
in the end. see docsWhen we only create the parent folder,
docker cp
will always create the DEST path and we don't have to expect the right format in the label./var/www/html/data/ -> /backups/local-cloud/var/www/html/data/
WIP: backup multiple pathsto backup multiple pathsLooking great! Thank you!
@ -72,6 +72,8 @@ else
fi
if [[ \ $*\ != *\ --skip-backup\ * ]]; then
rm -rf "${backup_path}"
Wondering if we can add a config option for this, but fine for the moment.
agree! I added this because I realized that the backupbots volume could potentially grow for ever in my usecase, as the copy doesn't delete any files that don't exist anymore. But for other usecases it might be good to disable it.
@ -83,3 +85,3 @@
if [ "$path" = "null" ]; then
echo "ERROR: missing 'path' for $service"
continue # or maybe exit?
continue # or maybe exit?
This was deliberate, but I guess there isn't much of a bash coding standard. Closest I could find is some random person on stackoverflow who agrees with me 🙃 https://stackoverflow.com/a/1496301/14269772
oh, I didn't intend to start a argument on coding style. I'll blame my opionated autoformatter for this one :D I'm totally fine having two spaces
i'll happily defer to comrade auto-formatter, great way to finish any arguments 😁