coop-cloud/backup-bot-two
6
0
Fork 4
Code Issues 13 Pull Requests 1 Packages Projects Releases Wiki Activity

backup multiple paths #5

Merged
3wordchant merged 4 commits from multi_path into main 2021-12-14 14:44:06 +00:00
Conversation 1 Commits 4 Files Changed 2 +17 -10
yksflip commented 2021-11-23 16:46:44 +00:00
Owner
Copy Link

still a wip because I'm still trying to understand the docker cp behaviour.

okay got my head around it:
docker cp has different behaviour if the DEST path already exists and there is a /. or / in the end. see docs

When we only create the parent folder, docker cp will always create the DEST path and we don't have to expect the right format in the label.

/var/www/html/data/ -> /backups/local-cloud/var/www/html/data/

still a wip because I'm still trying to understand the `docker cp` behaviour. ----- okay got my head around it: `docker cp` has different behaviour if the DEST path already exists and there is a `/.` or `/` in the end. see [docs](https://docs.docker.com/engine/reference/commandline/cp/#extended-description) When we only create the parent folder, `docker cp` will always create the DEST path and we don't have to expect the right format in the label. /var/www/html/data/ -> /backups/local-cloud/var/www/html/data/
❤️ 1
yksflip added 1 commit 2021-11-23 16:46:45 +00:00
make backup.path comma separated list
All checks were successful
continuous-integration/drone/pr Build is passing
Details
f2472bd0d3
yksflip added 1 commit 2021-11-24 10:17:30 +00:00
fix docker cp paths
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ce42fb06fd
yksflip changed title from WIP: backup multiple paths to backup multiple paths 2021-11-24 10:17:47 +00:00
yksflip added 1 commit 2021-11-24 10:29:28 +00:00
Merge branch 'main' into multi_path
All checks were successful
continuous-integration/drone/pr Build is passing
Details
5a20ef4349
yksflip added 1 commit 2021-12-13 10:38:14 +00:00
move rm up, to keep the latest backup in the volume
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d6faffcbbd
3wordchant approved these changes 2021-12-14 14:43:59 +00:00
3wordchant left a comment
Owner
Copy Link

Looking great! Thank you!

Looking great! Thank you!
backup.sh
@ -72,6 +72,8 @@ else
fi
if [[ \ $*\ != *\ --skip-backup\ * ]]; then
rm -rf "${backup_path}"
3wordchant commented 2021-12-14 14:40:45 +00:00
Owner
Copy Link

Wondering if we can add a config option for this, but fine for the moment.

Wondering if we can add a config option for this, but fine for the moment.
philippr commented 2021-12-14 18:03:11 +00:00
First-time contributor
Copy Link

agree! I added this because I realized that the backupbots volume could potentially grow for ever in my usecase, as the copy doesn't delete any files that don't exist anymore. But for other usecases it might be good to disable it.

agree! I added this because I realized that the backupbots volume could potentially grow for ever in my usecase, as the copy doesn't delete any files that don't exist anymore. But for other usecases it might be good to disable it.
backup.sh
@ -83,3 +85,3 @@
if [ "$path" = "null" ]; then
echo "ERROR: missing 'path' for $service"
continue # or maybe exit?
continue # or maybe exit?
3wordchant commented 2021-12-14 14:43:32 +00:00
Owner
Copy Link

This was deliberate, but I guess there isn't much of a bash coding standard. Closest I could find is some random person on stackoverflow who agrees with me 🙃 https://stackoverflow.com/a/1496301/14269772

This was deliberate, but I guess there isn't much of a bash coding standard. Closest I could find is some random person on stackoverflow who agrees with me 🙃 https://stackoverflow.com/a/1496301/14269772
philippr commented 2021-12-14 17:59:09 +00:00
First-time contributor
Copy Link

oh, I didn't intend to start a argument on coding style. I'll blame my opionated autoformatter for this one :D I'm totally fine having two spaces

oh, I didn't intend to start a argument on coding style. I'll blame my opionated autoformatter for this one :D I'm totally fine having two spaces
3wordchant commented 2021-12-14 21:06:33 +00:00
Owner
Copy Link

i'll happily defer to comrade auto-formatter, great way to finish any arguments 😁

i'll happily defer to comrade auto-formatter, great way to finish any arguments 😁
3wordchant merged commit 940b6bde1a into main 2021-12-14 14:44:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
3wordchant
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/backup-bot-two#5
No description provided.
Delete Branch "multi_path"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?