backup multiple paths #5

2021-11-23T16:46:44Z

yksflip commented

2021-11-23 16:46:44 +00:00

still a wip because I'm still trying to understand the docker cp behaviour.

okay got my head around it:
docker cp has different behaviour if the DEST path already exists and there is a /. or / in the end. see docs

When we only create the parent folder, docker cp will always create the DEST path and we don't have to expect the right format in the label.

/var/www/html/data/ -> /backups/local-cloud/var/www/html/data/

still a wip because I'm still trying to understand the `docker cp` behaviour. ----- okay got my head around it: `docker cp` has different behaviour if the DEST path already exists and there is a `/.` or `/` in the end. see [docs](https://docs.docker.com/engine/reference/commandline/cp/#extended-description) When we only create the parent folder, `docker cp` will always create the DEST path and we don't have to expect the right format in the label. /var/www/html/data/ -> /backups/local-cloud/var/www/html/data/

❤️ 1

yksflip added 1 commit 2021-11-23 16:46:45 +00:00

make backup.path comma separated list

continuous-integration/drone/pr Build is passing

Details

f2472bd0d3

yksflip added 1 commit 2021-11-24 10:17:30 +00:00

fix docker cp paths

continuous-integration/drone/pr Build is passing

Details

ce42fb06fd

yksflip marked the pull request as ready for review 2021-11-24 10:17:47 +00:00

yksflip added 1 commit 2021-11-24 10:29:28 +00:00

Merge branch 'main' into multi_path

continuous-integration/drone/pr Build is passing

Details

5a20ef4349

yksflip added 1 commit 2021-12-13 10:38:14 +00:00

move rm up, to keep the latest backup in the volume

continuous-integration/drone/pr Build is passing

Details

d6faffcbbd

3wordchant approved these changes 2021-12-14 14:43:59 +00:00

3wordchant left a comment

Looking great! Thank you!

backup.sh

						
				@@ -72,6 +72,8 @@ else

				fi

				if [[ \ $*\  != *\ --skip-backup\ * ]]; then

				    rm -rf "${backup_path}"

3wordchant commented

2021-12-14 14:40:45 +00:00

Wondering if we can add a config option for this, but fine for the moment.

philippr commented

2021-12-14 18:03:11 +00:00

First-time contributor

agree! I added this because I realized that the backupbots volume could potentially grow for ever in my usecase, as the copy doesn't delete any files that don't exist anymore. But for other usecases it might be good to disable it.

backup.sh

						
				@@ -83,3 +85,3 @@

							if [ "$path" = "null" ]; then

								echo "ERROR: missing 'path' for $service"

								continue  # or maybe exit?

								continue # or maybe exit?

3wordchant commented

2021-12-14 14:43:32 +00:00

This was deliberate, but I guess there isn't much of a bash coding standard. Closest I could find is some random person on stackoverflow who agrees with me 🙃 https://stackoverflow.com/a/1496301/14269772