some improvements #6

Merged
decentral1se merged 6 commits from make_foodsoft_work_again into main 2022-04-12 10:37:21 +00:00
Owner
  • remove default footer message, because abra can't parse it
  • new variables for nicks, locale
  • backupbot labels
  • remove "" from EMAIL_REPLY_DOMAIN as it builds invalid email syntax on an empty env
* remove default footer message, because abra can't parse it * new variables for nicks, locale * backupbot labels * remove "" from EMAIL_REPLY_DOMAIN as it builds invalid email syntax on an empty env
yksflip added 3 commits 2022-04-07 13:20:10 +00:00
afaik yml templating is no longer supported by abra?
not sure if there is a better way to reduce so much redundancy
add backupbot
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
c1bd006c62
decentral1se reviewed 2022-04-07 13:53:54 +00:00
decentral1se left a comment
Owner

Thanks so much for working on this! 🚀

Thanks so much for working on this! 🚀
compose.yml Outdated
@ -1,61 +1,60 @@
version: "3.8"
x-env: &env
Owner

Ah, wait a sec, I think abra can still deal with this it is just the weird !%21merge characters which somehow snuck into the config. I thought I resolved that in c5c0768b10 & 66b6992b0b? Without this admittedly not very nice YAML feature, the duplication of config is really getting too much, no?

Ah, wait a sec, I think `abra` can still deal with this it is just the weird `!%21merge` characters which somehow snuck into the config. I thought I resolved that in https://git.coopcloud.tech/coop-cloud/foodsoft/commit/c5c0768b10a274769c42672b49f45405fb0f72d0 & https://git.coopcloud.tech/coop-cloud/foodsoft/commit/66b6992b0b12fd4b64d686dca8870e07d91b281e? Without this admittedly not very nice YAML feature, the duplication of config is really getting too much, no?
Author
Owner

okay, I'll give it another try :)

okay, I'll give it another try :)
Author
Owner

nice, my eyes feel releaved!
a simple git fetch could have saved me some pain :D

nice, my eyes feel releaved! a simple git fetch could have saved me some pain :D
yksflip marked this conversation as resolved
compose.yml Outdated
@ -137,1 +204,3 @@
labels: ['coop-cloud.${STACK_NAME}.db.version=10.6-']
labels:
backupbot.backup: "true"
backupbot.backup.pre-hook: 'mkdir -p /tmp/backup/ && mysqldump --single-transaction -u root -p"$$(cat /run/secrets/db_root_password)" $${MYSQL_DATABASE} > /tmp/backup/backup.sql'
Owner

👏

👏
yksflip marked this conversation as resolved
yksflip added 1 commit 2022-04-07 14:18:29 +00:00
long live yml templates
Some checks failed
continuous-integration/drone/pr Build is failing
continuous-integration/drone/push Build is failing
42bdf49ba5
yksflip changed title from WIP: remove yml teplating and more to some improvements 2022-04-07 14:25:10 +00:00
yksflip added 1 commit 2022-04-07 15:18:37 +00:00
add group order invoice override
Some checks failed
continuous-integration/drone/pr Build is failing
continuous-integration/drone/push Build is failing
964610022b
decentral1se approved these changes 2022-04-07 16:13:19 +00:00
decentral1se left a comment
Owner

LGTM! There is just some conflicts listed below?

LGTM! There is just some conflicts listed below?
yksflip added 1 commit 2022-04-12 10:26:30 +00:00
merge
Some checks failed
continuous-integration/drone/pr Build is failing
continuous-integration/drone/push Build is failing
39fe337f38
decentral1se merged commit 3439069337 into main 2022-04-12 10:37:21 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/foodsoft#6
No description provided.