some improvements #6

yksflip · 2022-04-07T13:20:09Z

yksflip commented

2022-04-07 13:20:09 +00:00

remove default footer message, because abra can't parse it
new variables for nicks, locale
backupbot labels
remove "" from EMAIL_REPLY_DOMAIN as it builds invalid email syntax on an empty env

* remove default footer message, because abra can't parse it * new variables for nicks, locale * backupbot labels * remove "" from EMAIL_REPLY_DOMAIN as it builds invalid email syntax on an empty env

🎉 1

yksflip added 3 commits 2022-04-07 13:20:10 +00:00

a3e3713112 add nick, locale env ; fix email sender

9b20538e7b replace yml templating stuff

afaik yml templating is no longer supported by abra?
not sure if there is a better way to reduce so much redundancy

continuous-integration/drone/push Build is failing Details

continuous-integration/drone/pr Build is failing Details

c1bd006c62 add backupbot

decentral1se reviewed 2022-04-07 13:53:54 +00:00

decentral1se left a comment

Thanks so much for working on this! 🚀

compose.yml Outdated

						
				@ -1,61 +1,60 @@

				version: "3.8"

				x-env: &env

decentral1se commented

2022-04-07 13:53:08 +00:00

Ah, wait a sec, I think abra can still deal with this it is just the weird !%21merge characters which somehow snuck into the config. I thought I resolved that in c5c0768b10 & 66b6992b0b? Without this admittedly not very nice YAML feature, the duplication of config is really getting too much, no?

Ah, wait a sec, I think `abra` can still deal with this it is just the weird `!%21merge` characters which somehow snuck into the config. I thought I resolved that in https://git.coopcloud.tech/coop-cloud/foodsoft/commit/c5c0768b10a274769c42672b49f45405fb0f72d0 & https://git.coopcloud.tech/coop-cloud/foodsoft/commit/66b6992b0b12fd4b64d686dca8870e07d91b281e? Without this admittedly not very nice YAML feature, the duplication of config is really getting too much, no?

yksflip commented

2022-04-07 14:11:30 +00:00

okay, I'll give it another try :)

yksflip commented

2022-04-07 14:21:48 +00:00

nice, my eyes feel releaved!
a simple git fetch could have saved me some pain :D

nice, my eyes feel releaved! a simple git fetch could have saved me some pain :D

yksflip marked this conversation as resolved

compose.yml Outdated

						
				@ -137,1 +204,3 @@

				      labels: ['coop-cloud.${STACK_NAME}.db.version=10.6-']

				      labels:

				          backupbot.backup: "true"

				          backupbot.backup.pre-hook: 'mkdir -p /tmp/backup/ && mysqldump --single-transaction -u root -p"$$(cat /run/secrets/db_root_password)" $${MYSQL_DATABASE} > /tmp/backup/backup.sql'