coop-cloud/garage
2
0
Fork 0
Code Issues 6 Pull Requests 1 Projects 1 Releases Activity

feat: support sqlite and other database engines #6

Merged
marlon merged 2 commits from sqlite into main 2026-04-05 23:02:33 +00:00
Conversation 5 Commits 2 Files Changed 3
+5 -4
fauno commented 2026-04-03 15:07:02 +00:00
Owner
Copy Link
Copy Source

docs adverts lmdb can become corrupted on power outages

https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#db_engine

docs adverts lmdb can become corrupted on power outages https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#db_engine
fauno added 1 commit 2026-04-03 15:07:03 +00:00
feat: support sqlite and other database engines eb0079acf5 
docs adverts lmdb can become corrupted on power outages

https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#db_engine
fauno requested review from marlon 2026-04-03 15:07:03 +00:00
decentral1se reviewed 2026-04-03 15:50:12 +00:00
garage.toml.tmpl Outdated
@@ -1,6 +1,6 @@
metadata_dir = "/var/lib/garage/meta"
data_dir = "/var/lib/garage/data"
db_engine = "lmdb"
db_engine = "{{ env "DATABASE_ENGINE" }}"
decentral1se commented 2026-04-03 15:50:12 +00:00
Owner
Copy Link
Copy Source

You need to thread DATABASE_ENGINE into the compose.yml and keep the default of lmdb?

You need to thread `DATABASE_ENGINE` into the `compose.yml` and keep the default of `lmdb`?
fauno commented 2026-04-03 15:59:37 +00:00
Author
Owner
Copy Link
Copy Source

i can't parse this phrase 🤔

i can't parse this phrase 🤔
decentral1se commented 2026-04-03 16:11:45 +00:00
Owner
Copy Link
Copy Source

Ah, sorry, I thought you might need to add it to an environment: ... part in the compose.yml but you're using it directly in the .tmpl file. Ignore me 🙃

Ah, sorry, I thought you might need to add it to an `environment: ...` part in [the compose.yml](https://git.coopcloud.tech/coop-cloud/garage/src/branch/main/compose.yml#L5) but you're using it directly in the `.tmpl` file. Ignore me 🙃
decentral1se marked this conversation as resolved
decentral1se reviewed 2026-04-03 15:50:34 +00:00
.env.sample
@@ -11,6 +11,7 @@ SECRET_RPC_SECRET_VERSION=v1 # length=32 charset=hex
# supported and requires deleting the existing cluster layout metadata.
REPLICATION_FACTOR=2
DATABASE_ENGINE=lmdb
decentral1se commented 2026-04-03 15:50:34 +00:00
Owner
Copy Link
Copy Source

Seems like it might need a release note to explain?

Seems like it might need a release note to explain?
fauno commented 2026-04-03 15:58:56 +00:00
Author
Owner
Copy Link
Copy Source

i didn't think of it because it keeps the current behaviour intact!

i didn't think of it because it keeps the current behaviour intact!
decentral1se commented 2026-04-03 16:11:00 +00:00
Owner
Copy Link
Copy Source

For existing deployments, you need to add DATABASE_ENGINE to your .env or your upgrade will fail.

For existing deployments, you need to add `DATABASE_ENGINE` to your `.env` or your upgrade will fail.
fauno commented 2026-04-03 17:10:18 +00:00
Author
Owner
Copy Link
Copy Source

oh yeah, but abra app deploy also warns of missing env vars, right? i'll add a release note anyway, unless there's a default value for the env template function?

oh yeah, but abra app deploy also warns of missing env vars, right? i'll add a release note anyway, unless there's a default value for the env template function?
decentral1se commented 2026-04-03 17:13:24 +00:00
Owner
Copy Link
Copy Source

Yes, it warns but a release note is also good because people ignore warnings 😜 I don't think you can do a default env values, no 😬 Thanks!

Yes, it warns but a release note is also good because people ignore warnings 😜 I don't think you can do a default env values, no 😬 Thanks!
marlon added 1 commit 2026-04-04 20:22:25 +00:00
use lmdb by default if DATABASE_ENGINE not defined 05c953cd07
marlon commented 2026-04-04 20:23:15 +00:00
Owner
Copy Link
Copy Source

I added logic in the config template to default to lmdb if DATABASE_ENGINE is not defined. Does that resolve the problem?

I added logic in the config template to default to `lmdb` if `DATABASE_ENGINE` is not defined. Does that resolve the problem?
decentral1se commented 2026-04-05 14:39:25 +00:00
Owner
Copy Link
Copy Source

If you tested it and it works, then that looks fine! I thought you'd have to check != "" for truthiness of a string in the golang template? There's very little documentation about how to do this kind of thing, so manual testing is probably best.

If you tested it and it works, then that looks fine! I thought you'd have to check `!= ""` for truthiness of a string in the golang template? There's very little documentation about how to do this kind of thing, so manual testing is probably best.
marlon merged commit 22e218107e into main 2026-04-05 23:02:33 +00:00
fauno deleted branch sqlite 2026-04-06 12:43:50 +00:00
fauno commented 2026-04-06 12:44:38 +00:00
Author
Owner
Copy Link
Copy Source

@marlon thanks!

@decentral1se according to docs:

{{if pipeline}} T1 {{end}}
If the value of the pipeline is empty, no output is generated;
otherwise, T1 is executed. The empty values are false, 0, any
nil pointer or interface value, and any array, slice, map, or
string of length zero.

@marlon thanks! @decentral1se [according to docs](https://pkg.go.dev/text/template#hdr-Actions): > {{if pipeline}} T1 {{end}} > If the value of the pipeline is empty, no output is generated; > otherwise, T1 is executed. The empty values are false, 0, any > nil pointer or interface value, and any array, slice, map, or > string of length zero.
🚀 1
Sign in to join this conversation.
Reviewers
No Reviewers
marlon
decentral1se
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Help wanted
3
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm appletalk arjan basebuilder BornDeleuze Brooke carla cas (Cassowary) codegod100 coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) flancian Frando iexos jade (Jade Ambrose) javielico (Javielico) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) marlon (marlon) mayel mirsal moosemower moritz nicksellen (Nick Sellen) notplants oxaliq (sorrel) p4u1 pau pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) PhiNatalie renovate-bot (Comrade Renovate Bot) ripclap rix rscmbbng sef (sef) simon sixsmith (Sixsmith) stevensting tobias trav (Trav Fryer) val (val (he/him)) vaznasty virtualboys wolcen (Chris Thompson) wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/garage#6