coop-cloud/gitea
5
2
Fork 4
Code Issues 3 Pull Requests Releases Wiki Activity

feat: support other smtp protocols #39

Merged
fauno merged 2 commits from smtp into master 2025-01-07 20:12:17 +00:00
Conversation 4 Commits 2 Files Changed 4 +4 -2
fauno commented 2025-01-07 16:35:15 +00:00
Owner
Copy Link
No description provided.
fauno added 1 commit 2025-01-07 16:35:15 +00:00
feat: support other smtp protocols b84edcbe75
decentral1se reviewed 2025-01-07 16:48:48 +00:00
app.ini.tmpl
@ -72,3 +72,3 @@
ENABLED = true
FROM = {{ env "GITEA_MAILER_FROM" }}
PROTOCOL = smtps
PROTOCOL = {{ env "GITEA_MAILER_PROTOCOL" }}
decentral1se commented 2025-01-07 16:48:48 +00:00
Owner
Copy Link

This will break new deploys if they don't update their .env. We can either figure out a way to make backwards compatible (toolshed/organising#359) or add a warning in the release notes? I guess that would be a breaking change tho 🤔

This will break new deploys if they don't update their `.env`. We can either figure out a way to make backwards compatible (https://git.coopcloud.tech/toolshed/organising/issues/359) or add a warning in the release notes? I guess that would be a breaking change tho 🤔
decentral1se marked this conversation as resolved
decentral1se reviewed 2025-01-07 16:49:15 +00:00
decentral1se left a comment
Owner
Copy Link

💫

💫
fauno reviewed 2025-01-07 16:55:43 +00:00
compose.smtp.yml Outdated
@ -8,6 +8,7 @@ services:
- GITEA_MAILER_ADDR
- GITEA_MAILER_PORT
- GITEA_MAILER_USER
- GITEA_MAILER_PROTOCOL
fauno commented 2025-01-07 16:55:43 +00:00
Author
Owner
Copy Link

@decentral1se what about changing this to:

- GITEA_MAILER_PROTOCOL=${GITEA_MAILER_PROTOCOL:-smtps}
@decentral1se what about changing this to: ```yaml - GITEA_MAILER_PROTOCOL=${GITEA_MAILER_PROTOCOL:-smtps} ```
👍 1
decentral1se commented 2025-01-07 16:56:30 +00:00
Owner
Copy Link

Nice!

Nice!
decentral1se marked this conversation as resolved
fauno added 1 commit 2025-01-07 17:26:25 +00:00
fix: provide default fb45547f0d
decentral1se approved these changes 2025-01-07 17:30:53 +00:00
fauno merged commit e313c82857 into master 2025-01-07 20:12:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/gitea#39
No description provided.
Delete Branch "smtp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?