coop-cloud/gitea
3
1
Fork 7
Code Issues 7 Pull Requests 3 Releases Wiki Activity

feat: support other smtp protocols #39

Merged
fauno merged 0 commits from smtp into master 2025-01-07 20:12:17 +00:00
Conversation 4 Commits - Files Changed -
fauno commented 2025-01-07 16:35:15 +00:00
Owner
Copy Link
Copy Source
No description provided.
fauno added 1 commit 2025-01-07 16:35:15 +00:00
feat: support other smtp protocols b84edcbe75
decentral1se reviewed 2025-01-07 16:48:48 +00:00
app.ini.tmpl
@@ -72,3 +72,3 @@
ENABLED = true
FROM = {{ env "GITEA_MAILER_FROM" }}
PROTOCOL = smtps
PROTOCOL = {{ env "GITEA_MAILER_PROTOCOL" }}
decentral1se commented 2025-01-07 16:48:48 +00:00
Owner
Copy Link
Copy Source

This will break new deploys if they don't update their .env. We can either figure out a way to make backwards compatible (toolshed/organising#359) or add a warning in the release notes? I guess that would be a breaking change tho 🤔

This will break new deploys if they don't update their `.env`. We can either figure out a way to make backwards compatible (https://git.coopcloud.tech/toolshed/organising/issues/359) or add a warning in the release notes? I guess that would be a breaking change tho 🤔
decentral1se marked this conversation as resolved
decentral1se reviewed 2025-01-07 16:49:15 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

💫

💫
fauno reviewed 2025-01-07 16:55:43 +00:00
compose.smtp.yml Outdated
@@ -8,6 +8,7 @@ services:
- GITEA_MAILER_ADDR
- GITEA_MAILER_PORT
- GITEA_MAILER_USER
- GITEA_MAILER_PROTOCOL
fauno commented 2025-01-07 16:55:43 +00:00
Author
Owner
Copy Link
Copy Source

@decentral1se what about changing this to:

- GITEA_MAILER_PROTOCOL=${GITEA_MAILER_PROTOCOL:-smtps}
@decentral1se what about changing this to: ```yaml - GITEA_MAILER_PROTOCOL=${GITEA_MAILER_PROTOCOL:-smtps} ```
👍 1
decentral1se commented 2025-01-07 16:56:30 +00:00
Owner
Copy Link
Copy Source

Nice!

Nice!
decentral1se marked this conversation as resolved
fauno added 1 commit 2025-01-07 17:26:25 +00:00
fix: provide default fb45547f0d
decentral1se approved these changes 2025-01-07 17:30:53 +00:00
fauno merged commit e313c82857 into master 2025-01-07 20:12:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
fauno
decentral1se
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm appletalk arjan basebuilder BornDeleuze Brooke carla cas (Cassowary) codegod100 coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) flancian Frando iexos jade (Jade Ambrose) javielico (Javielico) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) marlon (marlon) mayel mirsal moosemower moritz nicksellen (Nick Sellen) notplants oxaliq (sorrel) p4u1 pau pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) PhiNatalie renovate-bot (Comrade Renovate Bot) ripclap rix rscmbbng sef (sef) simon sixsmith (Sixsmith) stevensting tobias trav (Trav Fryer) val (val (he/him)) vaznasty virtualboys wolcen (Chris Thompson) wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/gitea#39