coop-cloud/gitea
coop-cloud/gitea
5
2
Fork 4
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Add oauth2_client options to app.ini.tmpl #28

Closed
two-first-names wants to merge 0 commits from two-first-names/gitea:feature/gitea-oauth2-client into master
pull from: two-first-names/gitea:feature/gitea-oauth2-client
merge into: coop-cloud:master
Conversation 3 Commits - Files Changed 16 +50 -290
two-first-names commented 2022-09-19 15:55:41 +00:00
First-time contributor
Copy Link
No description provided.
two-first-names added 1 commit 2022-09-19 15:55:44 +00:00
Add oauth2_client options to app.ini.tmpl
Some checks failed
continuous-integration/drone/pr Build is failing
Details
9c591965d2
decentral1se requested changes 2022-09-19 16:11:18 +00:00
decentral1se left a comment
Owner
Copy Link

Nice! You'll need to follow up with a few changes:

  • bumping the app.ini.tmpl version in https://git.coopcloud.tech/coop-cloud/gitea/src/branch/master/abra.sh so that the config is upgraded when existing deployments roll out this new version (swarm configs are immutable)

  • adding the new env vars to https://git.coopcloud.tech/coop-cloud/gitea/src/branch/master/.env.sample so that folks know they can be config'd. if they're more optional, leave them commented out (don't forget to add GITEA_OAUTH2_CLIENT_ENABLED also)

  • thread the env vars through the environment: ... stanza so they are actually passed to the app itself in

    compose.yml Lines 18 to 34 in b757b806e4
    environment:
    - GITEA_ALLOW_ONLY_EXTERNAL_REGISTRATION
    - GITEA_APP_NAME
    - GITEA_AUTO_WATCH_NEW_REPOS
    - GITEA_DB_HOST="db:3306"
    - GITEA_DB_NAME=gitea
    - GITEA_DB_TYPE=mysql
    - GITEA_DB_USER=gitea
    - GITEA_DISABLE_REGISTRATION
    - GITEA_DOMAIN=${DOMAIN}
    - GITEA_ENABLE_NOTIFY_MAIL
    - GITEA_ENABLE_OPENID_SIGNIN
    - GITEA_ENABLE_OPENID_SIGNUP
    - GITEA_SMTP_MAILER_ENABLED
    - GITEA_SSH_PORT
    - GITEA_DISABLE_GRAVATAR
    - GITEA_ENABLE_FEDERATED_AVATAR
    (don't forget to add GITEA_OAUTH2_CLIENT_ENABLED also)

Nice! You'll need to follow up with a few changes: - bumping the `app.ini.tmpl` version in https://git.coopcloud.tech/coop-cloud/gitea/src/branch/master/abra.sh so that the config is upgraded when existing deployments roll out this new version (swarm configs are immutable) - adding the new env vars to https://git.coopcloud.tech/coop-cloud/gitea/src/branch/master/.env.sample so that folks know they can be config'd. if they're more optional, leave them commented out (don't forget to add `GITEA_OAUTH2_CLIENT_ENABLED` also) - thread the env vars through the `environment: ...` stanza so they are actually passed to the app itself in https://git.coopcloud.tech/coop-cloud/gitea/src/commit/b757b806e46308b90c3b1381b8fe19e02131de95/compose.yml#L18-L34 (don't forget to add `GITEA_OAUTH2_CLIENT_ENABLED` also)
decentral1se commented 2023-05-28 14:22:01 +00:00
Owner
Copy Link

heya @two-first-names, coming back to this - any updates?

heya @two-first-names, coming back to this - any updates?
decentral1se commented 2025-01-08 08:51:46 +00:00
Owner
Copy Link

Let's close this off for now, last comms 2 years ago.

Let's close this off for now, last comms 2 years ago.
decentral1se closed this pull request 2025-01-08 08:51:46 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud decentral1se fauno flancian Frando iexos javielico kawaiipunk knoflook lambdabundesverband mac-chaffee marlon mayel mirsal moritz nicksellen notplants p4u1 pau renovate-bot rix sef simon stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/gitea#28
No description provided.
Delete Branch "two-first-names/gitea:feature/gitea-oauth2-client"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?