feat: toggle push to create #40

Merged
fauno merged 1 commits from push-to-create into master 2025-01-08 12:53:04 +00:00
Owner
No description provided.
fauno added 1 commit 2025-01-07 16:43:17 +00:00
decentral1se reviewed 2025-01-07 16:50:54 +00:00
decentral1se left a comment
Owner

Missing the compose.*yml threading of env vars?

Missing the `compose.*yml` threading of env vars?
Author
Owner

Missing the compose.*yml threading of env vars?

Are they needed? I just deployed correctly without them, since they're only used on the app.ini template

> Missing the `compose.*yml` threading of env vars? Are they needed? I just deployed correctly without them, since they're only used on the app.ini template
Owner

I'm pretty sure you can deploy without them but then if you run env | grep GITEA_ENABLE_PUSH_CREATE_USERinside the container, it won't be exposed in the environment? The app_ini is in the config of the service.

I'm pretty sure you can deploy without them but then if you run `env | grep GITEA_ENABLE_PUSH_CREATE_USER`inside the container, it won't be exposed in the environment? The `app_ini` is in the config of the service.
Author
Owner

inside the container, it won't be exposed in the environment?

yeah i think that'd happened, but it's not required since gitea is already ignoring env vars prefixed GITEA_. i can add them if it's least surprise for operators

> inside the container, it won't be exposed in the environment? yeah i think that'd happened, but it's not required since gitea is already ignoring env vars prefixed GITEA_. i can add them if it's least surprise for operators
Author
Owner

i'm waiting for approval on this pr before releasing :D

i'm waiting for approval on this pr before releasing :D
decentral1se approved these changes 2025-01-08 08:51:10 +00:00
decentral1se left a comment
Owner

Ahhh I get it with the env var / template stuff, thanks!

Ahhh I get it with the env var / template stuff, thanks!
fauno merged commit b4fdbfdbbb into master 2025-01-08 12:53:04 +00:00
Sign in to join this conversation.
No description provided.