Perhaps reusing the COMPOSE_FILE value with strings.Contains for "compose.forgejo.yml" is also an option? I feel like people might forget that switch (FORGEJO) or not understand what it relates to (since it is only used now for the LFS functionality. Up to you!
Perhaps reusing the `COMPOSE_FILE` value with [`strings.Contains`](https://docs.gomplate.ca/functions/strings/#examples-1) for `"compose.forgejo.yml"` is also an option? I feel like people might forget that switch (`FORGEJO`) or not understand what it relates to (since it is only used now for the LFS functionality. Up to you!
i was thinking of setting ENVVAR=gitea for gitea and ENVVAR=forgejo, or even forking the recipe to make one exclusive for forgejo if they start being too different. i couldn't come up with a descriptive name for ENVVAR though
i was thinking of setting ENVVAR=gitea for gitea and ENVVAR=forgejo, or even forking the recipe to make one exclusive for forgejo if they start being too different. i couldn't come up with a descriptive name for ENVVAR though
@fauno tbh i think now that forgejo is a hard fork splitting up the recipe would be best (like we do for Mastodon/Hometown). but that's a bit of work... the ENVVAR approach is fine for now tho. Maybe open a ticket so we don't forget about it?
@fauno tbh i think now that forgejo is [a hard fork](https://forgejo.org/2024-02-forking-forward/) splitting up the recipe would be best (like we do for Mastodon/Hometown). but that's a bit of work... the `ENVVAR` approach is fine for now tho. Maybe open a ticket so we don't forget about it?
Looks good to me. Only comment is that if this isn't tested with Gitea, maybe let's add a comment to .env.sample to say so. Otherwise if it is, ready to merge I think!
Looks good to me. Only comment is that if this isn't tested with Gitea, maybe let's add a comment to `.env.sample` to say so. Otherwise if it is, ready to merge I think!
fauno
merged commit 5350ce207f into master2025-05-15 17:22:06 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
also added a way to adapt the app.ini template to forgejo variables
@@ -61,2 +61,4 @@SSH_PORT = {{ env "GITEA_SSH_PORT" }}START_SSH_SERVER = trueLFS_START_SERVER = {{ env "GITEA_LFS_START_SERVER" }}{{ if eq (env "FORGEJO") "1" }}Perhaps reusing the
COMPOSE_FILEvalue withstrings.Containsfor"compose.forgejo.yml"is also an option? I feel like people might forget that switch (FORGEJO) or not understand what it relates to (since it is only used now for the LFS functionality. Up to you!i was thinking of setting ENVVAR=gitea for gitea and ENVVAR=forgejo, or even forking the recipe to make one exclusive for forgejo if they start being too different. i couldn't come up with a descriptive name for ENVVAR though
@fauno tbh i think now that forgejo is a hard fork splitting up the recipe would be best (like we do for Mastodon/Hometown). but that's a bit of work... the
ENVVARapproach is fine for now tho. Maybe open a ticket so we don't forget about it?done!
Looks good to me. Only comment is that if this isn't tested with Gitea, maybe let's add a comment to
.env.sampleto say so. Otherwise if it is, ready to merge I think!