coop-cloud/gitea
4
2
Fork 6
Code Issues 7 Pull Requests 4 Releases Wiki Activity

change deploy logic to stop-first instead of start-first #53

Merged
notplants merged 3 commits from stop-first into master 2026-06-04 16:47:01 +00:00
Conversation 4 Commits 3 Files Changed 1 +2 -2
notplants commented 2026-05-18 16:57:57 +00:00
Owner
Copy Link

I believe that this change fixes the issue described here: #52

I believe doing stop-first instead of start-first causes the old container to be stopped before the new one is started (see: https://docs.docker.com/reference/compose-file/deploy/#update_config).

start-first allows for zero-downtime updates, but can lead to resource contention between old and new containers (which is maybe why we were seeing unable to lock level db at /var/lib/gitea/data/queues/common: resource temporarily unavailable in the error log in the issue mentioned).

not totally sure about this, but the theory makes sense to me, and the app was able to successfully deploy after the change

I believe that this change fixes the issue described here: https://git.coopcloud.tech/coop-cloud/gitea/issues/52 I believe doing `stop-first` instead of `start-first` causes the old container to be stopped before the new one is started (see: https://docs.docker.com/reference/compose-file/deploy/#update_config). `start-first` allows for zero-downtime updates, but can lead to resource contention between old and new containers (which is maybe why we were seeing `unable to lock level db at /var/lib/gitea/data/queues/common: resource temporarily unavailable` in the error log in the issue mentioned). not totally sure about this, but the theory makes sense to me, and the app was able to successfully deploy after the change
notplants added 1 commit 2026-05-18 16:57:57 +00:00
change deploy logic to stop-first instead of start-first c63e1cdd04
notplants added 1 commit 2026-05-18 16:59:20 +00:00
bump version number to 3.5.3 e7c4999f78
notplants commented 2026-05-18 17:02:53 +00:00
Author
Owner
Copy Link

cc recent committers if you have any thoughts or extra knowledge about this @3wordchant @fauno @p4u1

cc recent committers if you have any thoughts or extra knowledge about this @3wordchant @fauno @p4u1
fauno commented 2026-05-19 13:43:04 +00:00
Owner
Copy Link

i just tested it with forgejo and it works! i can see in the logs that the container receives the shutdown signal and then it starts the new container. i didn't even had to restart abra app logs

i just tested it with forgejo and it works! i can see in the logs that the container receives the shutdown signal and then it starts the new container. i didn't even had to restart abra app logs
👍 1
3wordchant commented 2026-05-28 16:51:37 +00:00
Owner
Copy Link

@notplants LGTM!

@notplants LGTM!
fauno reviewed 2026-05-28 20:47:23 +00:00
compose.yml Outdated
@ -88,3 +88,3 @@
- "traefik.http.middlewares.${STACK_NAME}_cors.headers.accesscontrolmaxage=100"
- "traefik.http.middlewares.${STACK_NAME}_cors.headers.addvaryheader=true"
- coop-cloud.${STACK_NAME}.version=3.5.2+1.24.2-rootless
- coop-cloud.${STACK_NAME}.version=3.5.3+1.24.2-rootless
fauno commented 2026-05-28 20:47:23 +00:00
Owner
Copy Link

i don't think you need to bump the version on the pr itself, because this will be done by the abra recipe upgrade gitea step, and it will complain there's nothing to do

i don't think you need to bump the version on the pr itself, because this will be done by the `abra recipe upgrade gitea` step, and it will complain there's nothing to do
notplants commented 2026-06-04 16:46:14 +00:00
Author
Owner
Copy Link

@fauna for some reason I have been in a habit of making the git tags manually instead of using abra recipe upgrade but maybe i should start using the actual tool (i think makes same result in the end though)

@fauna for some reason I have been in a habit of making the git tags manually instead of using `abra recipe upgrade` but maybe i should start using the actual tool (i think makes same result in the end though)
notplants added 1 commit 2026-06-04 16:46:33 +00:00
Merge branch 'master' into stop-first 34dd04ac99
notplants merged commit e6a1cc79e9 into master 2026-06-04 16:47:01 +00:00
notplants deleted branch stop-first 2026-06-04 16:47:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 amras Apfelwurm appletalk arjan basebuilder BornDeleuze Brooke carla cas codegod100 coopcloud cyrnel decentral1se dede devydave fauno flancian Frando iexos jade javielico jjsfunhouse jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie marlon mayel mirsal moosemower moritz nicksellen notplants oxaliq p4u1 pau pharaohgraphy PhiNatalie renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val vaznasty virtualboys wolcen wykwit xynosis yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/gitea#53
No description provided.
Delete Branch "stop-first"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?