App.LatestVersion() broken because maps are unordered #44

New Issue

decentral1se · 2021-08-06T12:54:08Z

decentral1se commented

2021-08-06 12:54:08 +00:00

We currently have LatestVersion function which purports to return the latest version of a recipe by iterating over a map of the versions listed for a recipe in the apps.json. This doesn't work because Golang maps are unordered. A potentially new version is returned each time...

Looks like this is actually broken in abra-bash also since we are doing mapfile -t RECIPE_VERSIONS < <(echo "$recipe_json" | $JQ -r ".versions | keys | .[]" - | sort) but a sort is not necessarily the actual latest/oldest order we need!

For example, wget -q https://registry.hub.docker.com/v1/repositories/gitea/gitea/tags -O - | jq -r '.[].name' returns the wrong order as well.

We could use a list instead in the apps.json. This would work because in the app-json.py script, we run a local git tags -l and iterate backwards through them - a latest/oldest order which we control (not upstream or Docker Hub).

We'd have to do the following:

Change get_app_versions to return a list in app-json.py
Change abra-bash to understand this new list in get_recipe_versions and make a new point release
Re-upload the the apps.json to https://apps.coopcloud.tech

/cc @roxxers @3wordchant

We currently have `LatestVersion` function which purports to return the latest version of a recipe by iterating over a map of the versions listed for a recipe in the `apps.json`. This doesn't work because Golang maps are unordered. A potentially new version is returned each time... Looks like this is actually broken in `abra-bash` also since we are doing `mapfile -t RECIPE_VERSIONS < <(echo "$recipe_json" | $JQ -r ".versions | keys | .[]" - | sort)` but a `sort` is not necessarily the actual latest/oldest order we need! For example, `wget -q https://registry.hub.docker.com/v1/repositories/gitea/gitea/tags -O - | jq -r '.[].name'` returns the wrong order as well. We could use a list instead in the `apps.json`. This would work because in the `app-json.py` script, we run a local `git tags -l` and iterate backwards through them - a latest/oldest order which we control (not upstream or Docker Hub). We'd have to do the following: - Change [`get_app_versions`](https://git.coopcloud.tech/coop-cloud/abra/src/commit/36e470c8e7129b20d8245b69192a04aafd798b85/bin/app-json.py#L142-L213) to return a list in `app-json.py` - Change `abra-bash` to understand this new list in [`get_recipe_versions`](https://git.coopcloud.tech/coop-cloud/abra/src/commit/36e470c8e7129b20d8245b69192a04aafd798b85/abra#L695-L707) and make a new point release - Re-upload the the `apps.json` to https://apps.coopcloud.tech /cc @roxxers @3wordchant

👀 1

decentral1se added the

bug

label 2021-08-06 12:54:08 +00:00

decentral1se referenced this issue

2021-09-03 16:54:01 +00:00

race condition in abra app new #64

roxxers referenced this issue

2021-09-03 19:01:00 +00:00

fix: tag sorting as map is unsorted #66

roxxers referenced this issue

2021-09-03 19:01:46 +00:00