toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix: tag sorting as map is unsorted #66

Closed
roxxers wants to merge 1 commits from fix/tag-sort into main
pull from: fix/tag-sort
merge into: toolshed:main
Conversation 2 Commits 1 Files Changed 1 +15 -4
roxxers commented 2021-09-03 19:01:00 +00:00
First-time contributor
Copy Link

Did this to fix #64 and #44 but I am unsure if its ok to merge given the issue I did in coop-cloud/tagcmp#2 since some tags cannot be parsed. Just want others to code review it before I merge it into main.

Did this to fix #64 and #44 but I am unsure if its ok to merge given the issue I did in coop-cloud/tagcmp#2 since some tags cannot be parsed. Just want others to code review it before I merge it into main.
roxxers added 1 commit 2021-09-03 19:01:01 +00:00
fix: tag sorting as map is unsorted
All checks were successful
continuous-integration/drone/pr Build is passing
Details
8cf3930518
decentral1se commented 2021-09-04 18:17:18 +00:00
Owner
Copy Link

Thanks! This is nice but other things like the https://dev.apps.coopcloud.tech won't have tagcmp to figure this out and perhaps other programs will want to consume the app listing, so I'd rather fix the data structure than working around it here in abra, following coop-cloud/go-abra#44 (comment) instead?

Thanks! This is nice but other things like the https://dev.apps.coopcloud.tech won't have `tagcmp` to figure this out and perhaps other programs will want to consume the app listing, so I'd rather fix the data structure than working around it here in abra, following https://git.coopcloud.tech/coop-cloud/go-abra/issues/44#issue-1892 instead?
decentral1se commented 2021-09-06 09:57:13 +00:00
Owner
Copy Link

I'll get out a fix for this today 👍

I'll get out a fix for this today 👍
decentral1se closed this pull request 2021-09-06 09:57:15 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#66
No description provided.
Delete Branch "fix/tag-sort"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?