Support tags with underscores that denote a new version with no bump from docker #2

New Issue

2021-09-03T18:27:01Z

roxxers commented

2021-09-03 18:27:01 +00:00

Noticing that a few versions we have in the recipes for abra have an underscore suffix like 1.2.3_1 and this seems to be when we have multiple tags for the same version. I recently added tagcmp's to the function to get the latest version but atm tagcmp does not consider this a valid tag. So we should add it in to work with these. Most likely that any tag with a _ is bigger than its non-suffixed version

Noticing that a few versions we have in the recipes for abra have an underscore suffix like `1.2.3_1` and this seems to be when we have multiple tags for the same version. I recently added tagcmp's to the function to get the latest version but atm tagcmp does not consider this a valid tag. So we should add it in to work with these. Most likely that any tag with a _ is bigger than its non-suffixed version

roxxers commented

2021-09-03 18:28:39 +00:00

Example error output from my abra patch

WARN[0000] 5.7.1_1 is not a valid tag: couldn't parse patch part of '5.7.1_1': '1_1'

Example error output from my abra patch ``` WARN[0000] 5.7.1_1 is not a valid tag: couldn't parse patch part of '5.7.1_1': '1_1'

roxxers referenced this issue from toolshed/abra

2021-09-03 19:01:00 +00:00

fix: tag sorting as map is unsorted #66

decentral1se commented

2021-09-04 18:17:50 +00:00

Would rather avoid writing this code, see coop-cloud/go-abra#66 (comment) for more.

Would rather avoid writing this code, see https://git.coopcloud.tech/coop-cloud/go-abra/pulls/66#issuecomment-8362 for more.

decentral1se commented

2021-09-06 10:05:13 +00:00

coop-cloud/go-abra#66 (comment)

https://git.coopcloud.tech/coop-cloud/go-abra/pulls/66#issuecomment-8406

decentral1se closed this issue

2021-09-06 10:05:15 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/tagcmp#2