coop-cloud/headscale
1
0
Fork 1
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

WIP: add cron job to download extra dns json file #5

Draft
ammaratef45 wants to merge 1 commits from dns_extra_records into main
pull from: dns_extra_records
merge into: coop-cloud:main
Conversation 2 Commits 1 Files Changed 7 +46 -3
ammaratef45 commented 2026-04-07 11:19:26 +00:00
Owner
Copy Link

Currently testing this, if someone interested in helping with test and/or review that would be appreciated

Currently testing this, if someone interested in helping with test and/or review that would be appreciated
ammaratef45 added 1 commit 2026-04-07 11:19:28 +00:00
add cron job to download extra dns json file 00a12a2164
decentral1se requested review from 3wordchant 2026-04-08 21:46:40 +00:00
3wordchant approved these changes 2026-04-09 17:09:35 +00:00
3wordchant left a comment
Owner
Copy Link

Awesome, thank you @ammaratef45 ! 🙏If you've tested a non-compose.dns.yml deployment and it works, I say go ahead and merge. Otherwise I will try to test it myself ASAP.

Awesome, thank you @ammaratef45 ! 🙏If you've tested a non-`compose.dns.yml` deployment and it works, I say go ahead and merge. Otherwise I will try to test it myself ASAP.
compose.dns.yml
@ -0,0 +12,4 @@
mode: replicated
replicas: 0
labels:
- "swarm.cronjob.enable=true"
3wordchant commented 2026-04-09 17:06:45 +00:00
Owner
Copy Link

Love it! For a million bonus points, it might be nice to add a fallback built-in cron option for folks who don't have / don't want a swarm-cronjob app? Highly optional though IMO.

Love it! For a million bonus points, it might be nice to add a fallback built-in cron option for folks who don't have / don't want a `swarm-cronjob` app? Highly optional though IMO.
ammaratef45 commented 2026-04-10 22:52:46 +00:00
Author
Owner
Copy Link

good idea, will look into this

good idea, will look into this
3wordchant commented 2026-04-11 21:00:04 +00:00
Owner
Copy Link

@ammaratef45 backup-bot-two is the only example I can think of that supports both:

Independent: https://git.coopcloud.tech/coop-cloud/backup-bot-two/src/branch/main/entrypoint.sh
swarm-cronjob: https://git.coopcloud.tech/coop-cloud/backup-bot-two/src/branch/main/compose.swarm-cronjob.yml

@ammaratef45 `backup-bot-two` is the only example I can think of that supports both: Independent: https://git.coopcloud.tech/coop-cloud/backup-bot-two/src/branch/main/entrypoint.sh `swarm-cronjob`: https://git.coopcloud.tech/coop-cloud/backup-bot-two/src/branch/main/compose.swarm-cronjob.yml
config.yaml.tmpl
@ -319,3 +319,3 @@
# Alternatively, extra DNS records can be loaded from a JSON file.
# Headscale processes this file on each change.
# extra_records_path: /var/lib/headscale/extra-records.json
extra_records_path: /var/lib/headscale/extra-records.json
3wordchant commented 2026-04-09 17:07:55 +00:00
Owner
Copy Link

Will this cause any problems for deployments not using compose.dns.yml? I wonder about putting this inside an {{ if ?

Will this cause any problems for deployments not using `compose.dns.yml`? I wonder about putting this inside an `{{ if `?
ammaratef45 commented 2026-04-10 22:54:51 +00:00
Author
Owner
Copy Link

No because I was a smart cookie and tested this and ended up putting extra_dns_records config in the main compose file

No because I was a smart cookie and tested this and ended up putting `extra_dns_records` config in the main compose file
❤️ 1
3wordchant marked this conversation as resolved
extra-downloader.sh
@ -0,0 +1,6 @@
apk add --no-cache --quiet wget
3wordchant commented 2026-04-09 17:08:52 +00:00
Owner
Copy Link

Could also inline this whole file as the entrypoint, given it's so short? No big deal either way though.

Could also inline this whole file as the `entrypoint`, given it's so short? No big deal either way though.
ammaratef45 commented 2026-04-10 22:55:59 +00:00
Author
Owner
Copy Link

hmm using the | operator you mean? that is smart and would save us needing to handle a config version!

hmm using the | operator you mean? that is smart and would save us needing to handle a config version!
extra-records.json
@ -0,0 +1 @@
[]
3wordchant commented 2026-04-09 17:05:51 +00:00
Owner
Copy Link

Could cheekily inline this into compose.dns.yml maybe? https://stackoverflow.com/a/77561067/14269772

Could cheekily inline this into `compose.dns.yml` maybe? https://stackoverflow.com/a/77561067/14269772
ammaratef45 commented 2026-04-10 22:56:49 +00:00
Author
Owner
Copy Link

yes will do that!

yes will do that!
ammaratef45 commented 2026-04-10 22:57:44 +00:00
Author
Owner
Copy Link

Awesome, thank you @ammaratef45 ! 🙏If you've tested a non-compose.dns.yml deployment and it works, I say go ahead and merge. Otherwise I will try to test it myself ASAP.

I did test that and it works but I just want to improve on this PR a bit more and take your suggestions!

> Awesome, thank you @ammaratef45 ! 🙏If you've tested a non-`compose.dns.yml` deployment and it works, I say go ahead and merge. Otherwise I will try to test it myself ASAP. I did test that and it works but I just want to improve on this PR a bit more and take your suggestions!
❤️ 1
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dns_extra_records:dns_extra_records
git checkout dns_extra_records
Sign in to join this conversation.
Reviewers
No Reviewers
3wordchant
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 amras BornDeleuze cas coopcloud decentral1se fauno jjsfunhouse kawaiipunk knoflook moosemower notplants oxaliq p4u1 renovate-bot stevensting trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/headscale#5
No description provided.
Delete Branch "dns_extra_records"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?