Add configuration option for maximum note length #8

wolcen · 2022-12-15T20:19:51Z

wolcen commented

2022-12-15 20:19:51 +00:00

This has worked for me/now takes full-effect on deploy.

DOCUMENT_MAX_LENGTH wasn't expected to be needed under environment in compose.yml, but it didn't seem to get picked up by the template until then, so apparently it is. Docs weren't unclear here, seems I just made assumption about template processing being "outside" that context 🤷

The "production" parent key is needed in the config. I hadn't picked that up at first. https://github.com/hedgedoc/hedgedoc/blob/master/lib/config/index.js#L35

Mode for config.json maybe should have been 0700, but I believe this caused an error when I tried that way. https://github.com/hedgedoc/container/blob/master/alpine/Dockerfile#L31

This has worked for me/now takes full-effect on deploy. DOCUMENT_MAX_LENGTH wasn't expected to be needed under environment in `compose.yml`, but it didn't seem to get picked up by the template until then, so apparently it is. Docs weren't unclear here, seems I just made assumption about template processing being "outside" that context :shrug: The "production" parent key is needed in the config. I hadn't picked that up at first. https://github.com/hedgedoc/hedgedoc/blob/master/lib/config/index.js#L35 Mode for config.json maybe should have been 0700, but I believe this caused an error when I tried that way. https://github.com/hedgedoc/container/blob/master/alpine/Dockerfile#L31

wolcen added 5 commits 2022-12-15 20:19:53 +00:00

Add config file template for documentMaxLength setting 0c96d5a45f

Correct link 6139cff626

Corrections to get config updating and effective 9e88945b9b

Bump configuration version 7780eb9f13

Closing `'s seem not required when indented

continuous-integration/drone/pr Build is failing

Details

8e973cbed1

Otherwise, extra `` prints on README display.

decentral1se approved these changes 2022-12-15 20:29:09 +00:00

decentral1se left a comment

LGTM, Thanks!

decentral1se merged commit b43724ecba into main

2022-12-15 20:29:18 +00:00

decentral1se referenced this issue from a commit

2022-12-15 20:29:19 +00:00

Merge pull request 'Add configuration option for maximum note length' (#8) from wolcen/hedgedoc:main into main

3wordchant commented

2022-12-16 00:06:45 +00:00

@wolcen thanks so much for the contribution! 🙏

Mode for config.json maybe should have been 0700, but I believe this caused an error when I tried that way. https://github.com/hedgedoc/container/blob/master/alpine/Dockerfile#L31

Does it work without the mode line?

@wolcen thanks so much for the contribution! 🙏 > Mode for config.json maybe should have been 0700, but I believe this caused an error when I tried that way. https://github.com/hedgedoc/container/blob/master/alpine/Dockerfile#L31 Does it work without the `mode` line?

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/hedgedoc#8

Allow edits from maintainers