add_kcadm #28
Reference in New Issue
Block a user
No description provided.
Delete Branch "oxaliq/keycloak:add_kcadm"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #27
There is a subtle breaking change introduced, as the semantics of the admin_password secret are changed. kcadm.sh requires authentication against the Keycloak REST API for a user of sufficient permissions to perform the actions attempted. To solve this, this PR uses the admin_password secret as the secret for the permanent admin user that is created after authenticating with the temporary bootstrapped user.
The result is that running
login_kcadmandrun_kcadmwill not work for existing Keycloak deployments without upgrading this secret. I can write a short guide on how to do this if this PR is accepted.adding reviewers from recent recipe activity. ty!
OK, I tried to grok this breaking issue but my brain won't let it in 😆 Can you write up the short migration guide in a release note and that might help?
This looks like a solid change in general! Just want to get the breaking stuff agreed upon by a few people. I think the release note will help.
Added a release note! thanks @decentral1se
Keycloak is hands down the most bizarre software 😆 Great work! I think I've reached the limits of evaluating this PR. I don't maintain Keycloak anymore. I hope the others can weigh in. You might need to chase them up on the Matrix chats.
@ -6,3 +6,3 @@LETS_ENCRYPT_ENV=productionADMIN_USERNAME=adminBOOTSTRAP_PASSWORD= # temporary admin passwordDo I understand that you want operators to set this secret value themselves manually? That seems fine since it is temporary but it is a bit of an unexpected context switch. I don't think any other single recipe asks operators to put plain secrets in their
.envfiles. How annoying is it to generate this temporary secret and remove it after you runinit_kc? That would be more "standard" 😬That makes sense! I was hoping to really highlight how this password should not be relied upon, but I can make it a temporary secret again to avoid a strange pattern.
@ -0,0 +12,4 @@To insert your permanent admin password:"abra app secret insert $APP SECRET_ADMIN_PASSWORD_VERSION \$NEW_VERSION $ADMIN_PASSWORD"Do we want to qualify here that
$ADMIN_PASSWORDis the 2nd password they entered in manually in the web UI when creating their "permanent admin" in the previous workflow? Idk how others see this but I'm really confused but this whole change because Keycloak is just so weird 😅I'll add more language to that effect. I was really struggling with how to delineate the two passwords. The pattern is super strange!
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.