Fix poorly formed json in OIDC_AUTH_REQUEST_EXTRA_PARAMS #7

notplants · 2025-09-25T22:52:58Z

notplants commented

2025-09-25 22:52:58 +00:00

This appears to get the backend service to run, which gets nginx to run. The app properly loaded after this change.

Didn't get around to fully testing keycloak integration (probably next step)

This appears to get the backend service to run, which gets nginx to run. The app properly loaded after this change. Didn't get around to fully testing keycloak integration (probably next step)

🎉 2

notplants added 1 commit 2025-09-25 22:52:59 +00:00

Fix poorly formed json in OIDC_AUTH_REQUEST_EXTRA_PARAMS 20649c56d7

decentral1se commented

2025-09-27 15:02:28 +00:00

Seems like @3wordchant might be the one to ask about this as far as I can tell from 7b00a0ff4c

Seems like @3wordchant might be the one to ask about this as far as I can tell from https://git.coopcloud.tech/coop-cloud/lasuite-docs/commit/7b00a0ff4c8f5bd5ef65d30116593e03bb2e7450

trav approved these changes 2025-10-01 14:55:09 +00:00

trav left a comment

nice (also oops I shouldn't have rushed to approve this, waiting to merge...), looks good so far though

3wordchant commented

2025-10-08 15:33:38 +00:00

@notplants great spot!

Definitely with = I'm seeing these errors on the backend container:

  File "<unknown>", line 1
    {'acr_values'='eidas1'}
     ^^^^^^^^^^^^
SyntaxError: cannot assign to literal here. Maybe you meant '==' instead of '='?

I think it's parsing it as a Python dict, so the quotation marks shouldn't matter (and it works for me without that part of the change) but I don't think the change harms anything either.

@notplants great spot! Definitely with `=` I'm seeing these errors on the `backend` container: ``` File "<unknown>", line 1 {'acr_values'='eidas1'} ^^^^^^^^^^^^ SyntaxError: cannot assign to literal here. Maybe you meant '==' instead of '='? ``` I think [it's parsing it as a Python dict](https://github.com/suitenumerique/docs/blob/dc25f3f39c59a872e9282de1c9e96eda8cdbdd9a/src/backend/impress/settings.py#L558), so the quotation marks shouldn't matter (and it works for me without that part of the change) but I don't think the change harms anything either.

3wordchant merged commit 9a190c92cb into main

2025-10-08 15:33:42 +00:00

3wordchant referenced this issue from a commit

2025-10-08 15:33:44 +00:00

Merge pull request 'Fix poorly formed json in OIDC_AUTH_REQUEST_EXTRA_PARAMS' (#7) from notplants/lasuite-docs:fix-json into main

Sign in to join this conversation.

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/lasuite-docs#7

Allow edits from maintainers